Re: [PATCH 01/33] lib: devres: Introduce devm_ioremap_resource()

2013-01-22 Thread Thierry Reding
On Tue, Jan 22, 2013 at 09:40:43AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 21, 2013 at 11:08:54AM +0100, Thierry Reding wrote: > > The devm_request_and_ioremap() function is very useful and helps avoid a > > whole lot of boilerplate. However, one issue that keeps popping up is > > its lack o

Re: [PATCH 01/33] lib: devres: Introduce devm_ioremap_resource()

2013-01-22 Thread Greg Kroah-Hartman
On Mon, Jan 21, 2013 at 11:08:54AM +0100, Thierry Reding wrote: > The devm_request_and_ioremap() function is very useful and helps avoid a > whole lot of boilerplate. However, one issue that keeps popping up is > its lack of a specific error code to determine which of the steps that > it performs f

Re: [PATCH 01/33] lib: devres: Introduce devm_ioremap_resource()

2013-01-21 Thread Dmitry Torokhov
On Mon, Jan 21, 2013 at 11:08:54AM +0100, Thierry Reding wrote: > The devm_request_and_ioremap() function is very useful and helps avoid a > whole lot of boilerplate. However, one issue that keeps popping up is > its lack of a specific error code to determine which of the steps that > it performs f

[PATCH 01/33] lib: devres: Introduce devm_ioremap_resource()

2013-01-21 Thread Thierry Reding
The devm_request_and_ioremap() function is very useful and helps avoid a whole lot of boilerplate. However, one issue that keeps popping up is its lack of a specific error code to determine which of the steps that it performs failed. Furthermore, while the function gives an example and suggests wha