Re: [PATCH 01/33] usb: phy: use match_string() helper

Hi, On 2018/5/22 18:02, Greg Kroah-Hartman wrote: > On Tue, May 22, 2018 at 01:20:01AM +0300, Andy Shevchenko wrote: >> On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: >>> match_string() returns the index of an array for a matching string, >>> which can be used intead of open coded variant. >

Re: [PATCH 01/33] usb: phy: use match_string() helper

On Tue, May 22, 2018 at 01:20:01AM +0300, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: > > match_string() returns the index of an array for a matching string, > > which can be used intead of open coded variant. > > > - int err, i; > > + int ret; > > in

Re: [PATCH 01/33] usb: phy: use match_string() helper

On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: > match_string() returns the index of an array for a matching string, > which can be used intead of open coded variant. > - int err, i; > + int ret; int err; would still work. -- With Best Regards, Andy Shevchenko

[PATCH 01/33] usb: phy: use match_string() helper

match_string() returns the index of an array for a matching string, which can be used intead of open coded variant. Cc: linux-...@vger.kernel.org Cc: Felipe Balbi Cc: Greg Kroah-Hartman Signed-off-by: Yisheng Xie --- drivers/usb/phy/of.c | 12 +--- 1 file changed, 5 insertions(+), 7 de