Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros

2016-03-20 Thread Hugh Dickins
On Sun, 20 Mar 2016, Linus Torvalds wrote: > On Sun, Mar 20, 2016 at 12:34 PM, Kirill A. Shutemov > wrote: > > > > Hm. Okay. Re-split this way would take some time. I'll post updated > > patchset tomorrow. > > Oh, I was assuming this was automated with coccinelle or at least some > simple shell s

Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros

2016-03-20 Thread Linus Torvalds
On Sun, Mar 20, 2016 at 12:34 PM, Kirill A. Shutemov wrote: > > Hm. Okay. Re-split this way would take some time. I'll post updated > patchset tomorrow. Oh, I was assuming this was automated with coccinelle or at least some simple shell scripting.. Generally, for things like this, automation rea

Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros

2016-03-20 Thread Kirill A. Shutemov
On Sun, Mar 20, 2016 at 12:13:47PM -0700, Linus Torvalds wrote: > On Sun, Mar 20, 2016 at 12:00 PM, Al Viro wrote: > >> > >> It doesn't help legibility or testing, so let's just do it in one big go. > > > > Might make sense splitting it by the thing being removed, though - easier > > to visually v

Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros

2016-03-20 Thread Linus Torvalds
On Sun, Mar 20, 2016 at 12:00 PM, Al Viro wrote: >> >> It doesn't help legibility or testing, so let's just do it in one big go. > > Might make sense splitting it by the thing being removed, though - easier > to visually verify that it's doing the right thing when all replacements > are of the sam

Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros

2016-03-20 Thread Al Viro
On Sun, Mar 20, 2016 at 11:54:56AM -0700, Linus Torvalds wrote: > I'm OK with this, but let's not do this as a hundred small patches, OK? > > It doesn't help legibility or testing, so let's just do it in one big go. Might make sense splitting it by the thing being removed, though - easier to visu

[PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros

2016-03-20 Thread Kirill A. Shutemov
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time ago with promise that one day it will be possible to implement page cache with bigger chunks than PAGE_SIZE. This promise never materialized. And unlikely will. We have many places where PAGE_CACHE_SIZE assumed to be equal to P