Re: [PATCH 02/10] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED

2019-09-13 Thread David Hildenbrand
On 12.09.19 03:37, Naoya Horiguchi wrote: > On Wed, Sep 11, 2019 at 12:27:22PM +0200, David Hildenbrand wrote: >> On 10.09.19 12:30, Oscar Salvador wrote: >>> From: Naoya Horiguchi >>> >>> Currently madvise_inject_error() pins the target via get_user_pages_fast. >>> The call to

Re: [PATCH 02/10] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED

2019-09-11 Thread Naoya Horiguchi
On Wed, Sep 11, 2019 at 12:27:22PM +0200, David Hildenbrand wrote: > On 10.09.19 12:30, Oscar Salvador wrote: > > From: Naoya Horiguchi > > > > Currently madvise_inject_error() pins the target via get_user_pages_fast. > > The call to get_user_pages_fast is only to get the respective page > > of

Re: [PATCH 02/10] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED

2019-09-11 Thread Naoya Horiguchi
Hi David, On Wed, Sep 11, 2019 at 12:23:24PM +0200, David Hildenbrand wrote: > On 10.09.19 12:30, Oscar Salvador wrote: > > From: Naoya Horiguchi > > > > Currently madvise_inject_error() pins the target via get_user_pages_fast. > > The call to get_user_pages_fast is only to get the respective

Re: [PATCH 02/10] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED

2019-09-11 Thread David Hildenbrand
On 10.09.19 12:30, Oscar Salvador wrote: > From: Naoya Horiguchi > > Currently madvise_inject_error() pins the target via get_user_pages_fast. > The call to get_user_pages_fast is only to get the respective page > of a given address, but it is the job of the memory-poisoning handler > to deal

Re: [PATCH 02/10] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED

2019-09-11 Thread David Hildenbrand
On 10.09.19 12:30, Oscar Salvador wrote: > From: Naoya Horiguchi > > Currently madvise_inject_error() pins the target via get_user_pages_fast. > The call to get_user_pages_fast is only to get the respective page > of a given address, but it is the job of the memory-poisoning handler > to deal

[PATCH 02/10] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED

2019-09-10 Thread Oscar Salvador
From: Naoya Horiguchi Currently madvise_inject_error() pins the target via get_user_pages_fast. The call to get_user_pages_fast is only to get the respective page of a given address, but it is the job of the memory-poisoning handler to deal with races, so drop the refcount grabbed by