Re: [PATCH 02/10] mm: Maintain memcg-aware shrinkers in mcg_shrinkers array

2018-03-27 Thread Kirill Tkhai
On 27.03.2018 12:18, Vladimir Davydov wrote: > On Mon, Mar 26, 2018 at 06:20:55PM +0300, Kirill Tkhai wrote: >> On 24.03.2018 21:45, Vladimir Davydov wrote: >>> On Wed, Mar 21, 2018 at 04:21:29PM +0300, Kirill Tkhai wrote: The patch introduces mcg_shrinkers array to keep memcg-aware shrin

Re: [PATCH 02/10] mm: Maintain memcg-aware shrinkers in mcg_shrinkers array

2018-03-27 Thread Vladimir Davydov
On Mon, Mar 26, 2018 at 06:20:55PM +0300, Kirill Tkhai wrote: > On 24.03.2018 21:45, Vladimir Davydov wrote: > > On Wed, Mar 21, 2018 at 04:21:29PM +0300, Kirill Tkhai wrote: > >> The patch introduces mcg_shrinkers array to keep memcg-aware > >> shrinkers in order of their shrinker::id. > >> > >> T

Re: [PATCH 02/10] mm: Maintain memcg-aware shrinkers in mcg_shrinkers array

2018-03-26 Thread Matthew Wilcox
On Mon, Mar 26, 2018 at 06:20:55PM +0300, Kirill Tkhai wrote: > On 24.03.2018 21:45, Vladimir Davydov wrote: > > Why don't you simply use idr instead of ida? With idr you wouldn't need > > the array mapping shrinker id to shrinker ptr. AFAIU you need this > > mapping to look up the shrinker by id i

Re: [PATCH 02/10] mm: Maintain memcg-aware shrinkers in mcg_shrinkers array

2018-03-26 Thread Kirill Tkhai
On 24.03.2018 21:45, Vladimir Davydov wrote: > On Wed, Mar 21, 2018 at 04:21:29PM +0300, Kirill Tkhai wrote: >> The patch introduces mcg_shrinkers array to keep memcg-aware >> shrinkers in order of their shrinker::id. >> >> This allows to access the shrinkers dirrectly by the id, >> without iterati

Re: [PATCH 02/10] mm: Maintain memcg-aware shrinkers in mcg_shrinkers array

2018-03-24 Thread Vladimir Davydov
On Wed, Mar 21, 2018 at 04:21:29PM +0300, Kirill Tkhai wrote: > The patch introduces mcg_shrinkers array to keep memcg-aware > shrinkers in order of their shrinker::id. > > This allows to access the shrinkers dirrectly by the id, > without iteration over shrinker_list list. Why don't you simply u

[PATCH 02/10] mm: Maintain memcg-aware shrinkers in mcg_shrinkers array

2018-03-21 Thread Kirill Tkhai
The patch introduces mcg_shrinkers array to keep memcg-aware shrinkers in order of their shrinker::id. This allows to access the shrinkers dirrectly by the id, without iteration over shrinker_list list. Signed-off-by: Kirill Tkhai --- mm/vmscan.c | 89 +