Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Mark Brown
On Mon, Nov 18, 2013 at 05:32:01PM +, Lee Jones wrote: > I can get a patch out tomorrow if the MTD guys agree. Where are they > by the way? I haven't seen hide nor hair of them since sending out the > patch set. They tend to do big batches of things intermittently AFAICT. signature.asc Desc

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Sourav Poddar
On Monday 18 November 2013 11:02 PM, Lee Jones wrote: On Mon, 18 Nov 2013, Mark Brown wrote: On Mon, Nov 18, 2013 at 04:02:26PM +, Lee Jones wrote: On Mon, 18 Nov 2013, Mark Brown wrote: Like I say I'm suggesting that the bit of the code that understands the flash chip is separate to the

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Lee Jones
On Mon, 18 Nov 2013, Mark Brown wrote: > On Mon, Nov 18, 2013 at 04:02:26PM +, Lee Jones wrote: > > On Mon, 18 Nov 2013, Mark Brown wrote: > > > > Like I say I'm suggesting that the bit of the code that understands the > > > flash chip is separate to the bit of code that knows the mechanics o

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Mark Brown
On Mon, Nov 18, 2013 at 04:02:26PM +, Lee Jones wrote: > On Mon, 18 Nov 2013, Mark Brown wrote: > > Like I say I'm suggesting that the bit of the code that understands the > > flash chip is separate to the bit of code that knows the mechanics of > > sending commands and data to the chip. > Th

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Lee Jones
On Mon, 18 Nov 2013, Mark Brown wrote: > On Mon, Nov 18, 2013 at 03:31:10PM +, Lee Jones wrote: > > On Mon, 18 Nov 2013, Mark Brown wrote: > > > > This doesn't seem realistic, you're assuming that system integrators > > > won't go and use chips you've not heard of and at least in the case of

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Mark Brown
On Mon, Nov 18, 2013 at 03:31:10PM +, Lee Jones wrote: > On Mon, 18 Nov 2013, Mark Brown wrote: > > This doesn't seem realistic, you're assuming that system integrators > > won't go and use chips you've not heard of and at least in the case of > > things like quad read my understanding is that

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Lee Jones
On Mon, 18 Nov 2013, Mark Brown wrote: > On Mon, Nov 18, 2013 at 02:56:14PM +, Lee Jones wrote: > > > I think it's a good idea for people using the m25p80, but still > > doesn't effect us. All of our chips are dynamically probable. We are > > This doesn't seem realistic, you're assuming that

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Mark Brown
On Mon, Nov 18, 2013 at 02:56:14PM +, Lee Jones wrote: > I think it's a good idea for people using the m25p80, but still > doesn't effect us. All of our chips are dynamically probable. We are This doesn't seem realistic, you're assuming that system integrators won't go and use chips you've no

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Lee Jones
On Mon, 18 Nov 2013, Mark Brown wrote: > On Mon, Nov 18, 2013 at 02:24:47PM +, Lee Jones wrote: > > > For example, we have thought about inserting a layer which handles the > > type of communication that'll be utilised i.e. true SPI, or our > > bespoke FSM implementation for instance. This wo

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Mark Brown
On Mon, Nov 18, 2013 at 02:24:47PM +, Lee Jones wrote: > For example, we have thought about inserting a layer which handles the > type of communication that'll be utilised i.e. true SPI, or our > bespoke FSM implementation for instance. This would enable us to issue > serial_flash_write(), ser

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Lee Jones
On Mon, 18 Nov 2013, Mark Brown wrote: > On Mon, Nov 18, 2013 at 09:32:29AM +, Lee Jones wrote: > > > I've actually travelled down the route of separating the SPI > > Controller parts to drivers/spi. It's possible to do that and perhaps > > we could then use the generic m25p80 Serial Flash dr

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Mark Brown
On Mon, Nov 18, 2013 at 09:32:29AM +, Lee Jones wrote: > I've actually travelled down the route of separating the SPI > Controller parts to drivers/spi. It's possible to do that and perhaps > we could then use the generic m25p80 Serial Flash driver as the > back-end, but it would be incredibly

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Lee Jones
On Mon, 18 Nov 2013, Linus Walleij wrote: > On Thu, Nov 14, 2013 at 3:22 PM, Lee Jones wrote: > > > Here we provide the FSM's register addresses, register bit names/offsets > > and some commands which will prove useful as we start bulk the FMS's > > driver out with functionality. > > > > Signed-

Re: [PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-18 Thread Linus Walleij
On Thu, Nov 14, 2013 at 3:22 PM, Lee Jones wrote: > Here we provide the FSM's register addresses, register bit names/offsets > and some commands which will prove useful as we start bulk the FMS's > driver out with functionality. > > Signed-off-by: Lee Jones OK... > +/* > + * FSM SPI Controller

[PATCH 02/10] mtd: st_spi_fsm: Supply all register address and bit logic defines

2013-11-14 Thread Lee Jones
Here we provide the FSM's register addresses, register bit names/offsets and some commands which will prove useful as we start bulk the FMS's driver out with functionality. Signed-off-by: Lee Jones --- drivers/mtd/devices/st_spi_fsm.h | 183 +++ 1 file changed