Re: [PATCH 02/11] radeon: evergreen: Fix probable mask then right shift defects

2014-10-27 Thread Michel Dänzer
On 27.10.2014 14:24, Joe Perches wrote: Precedence of & and >> is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Use the already #defined values instead of hardcoding. Signed-off-by: Joe Perches ---

Re: [PATCH 02/11] radeon: evergreen: Fix probable mask then right shift defects

2014-10-27 Thread Michel Dänzer
On 27.10.2014 14:24, Joe Perches wrote: Precedence of and is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Use the already #defined values instead of hardcoding. Signed-off-by: Joe Perches

[PATCH 02/11] radeon: evergreen: Fix probable mask then right shift defects

2014-10-26 Thread Joe Perches
Precedence of & and >> is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Use the already #defined values instead of hardcoding. Signed-off-by: Joe Perches --- drivers/gpu/drm/radeon/evergreen.c | 3 ++- 1

[PATCH 02/11] radeon: evergreen: Fix probable mask then right shift defects

2014-10-26 Thread Joe Perches
Precedence of and is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Use the already #defined values instead of hardcoding. Signed-off-by: Joe Perches j...@perches.com ---