Re: [PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-24 Thread Ingo Molnar
* David Herrmann wrote: > Hi > > On Thu, Jan 23, 2014 at 6:14 PM, Ingo Molnar wrote: > > > > * David Herrmann wrote: > > > >> >> +#ifdef CONFIG_X86_SYSFB > >> >> +# include > >> >> +#endif > >> > > >> > I guess a single space is sufficient? > >> > > >> > Better yet, I'd include sysfb.h unco

Re: [PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-23 Thread David Herrmann
Hi On Thu, Jan 23, 2014 at 6:14 PM, Ingo Molnar wrote: > > * David Herrmann wrote: > >> >> +#ifdef CONFIG_X86_SYSFB >> >> +# include >> >> +#endif >> > >> > I guess a single space is sufficient? >> > >> > Better yet, I'd include sysfb.h unconditionally: >> >> Unconditionally won't work as only

Re: [PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-23 Thread Ingo Molnar
* David Herrmann wrote: > >> +#ifdef CONFIG_X86_SYSFB > >> +# include > >> +#endif > > > > I guess a single space is sufficient? > > > > Better yet, I'd include sysfb.h unconditionally: > > Unconditionally won't work as only x86 has this header. [...] Well, in non-x86 code an #ifdef x86 look

Re: [PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-23 Thread David Herrmann
Hi On Thu, Jan 23, 2014 at 5:51 PM, Ingo Molnar wrote: > > Just a couple of small nits: > > * David Herrmann wrote: > >> --- a/arch/x86/kernel/sysfb.c >> +++ b/arch/x86/kernel/sysfb.c >> @@ -33,11 +33,76 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #

Re: [PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-23 Thread Ingo Molnar
Just a couple of small nits: * David Herrmann wrote: > --- a/arch/x86/kernel/sysfb.c > +++ b/arch/x86/kernel/sysfb.c > @@ -33,11 +33,76 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > > +static DEFINE_MUTEX(sysfb_lock); > +static st

[PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-23 Thread David Herrmann
With CONFIG_X86_SYSFB=y, probing real hw-drivers may result in resource-conflicts and drivers will refuse to load. A call to request_mem_region() will fail, if the region overlaps with the mem-region used by simplefb. The common desktop DRM drivers (intel, nouveau, radeon) are not affected as they