[PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create()

2017-06-17 Thread NeilBrown
"flags" arguments are often seen as good API design as they allow easy extensibility. bioset_create_nobvec() is implemented internally as a variation in flags passed to __bioset_create(). To support future extension, make the internal structure part of the API. i.e. add a 'flags' argument to biose

Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create()

2017-05-02 Thread NeilBrown
On Tue, May 02 2017, Christoph Hellwig wrote: >> diff --git a/include/linux/bio.h b/include/linux/bio.h >> index d1b04b0e99cf..0975da6bebd9 100644 >> --- a/include/linux/bio.h >> +++ b/include/linux/bio.h >> @@ -373,8 +373,10 @@ static inline struct bio *bio_next_split(struct bio >> *bio, int sec

Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create()

2017-05-02 Thread Ming Lei
On Tue, May 02, 2017 at 01:42:24PM +1000, NeilBrown wrote: > "flags" arguments are often seen as good API design as they allow > easy extensibility. > bioset_create_nobvec() is implemented internally as a variation in > flags passed to __bioset_create(). >From driver's view, this flag has document

Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create()

2017-05-02 Thread Christoph Hellwig
> diff --git a/include/linux/bio.h b/include/linux/bio.h > index d1b04b0e99cf..0975da6bebd9 100644 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -373,8 +373,10 @@ static inline struct bio *bio_next_split(struct bio > *bio, int sectors, > return bio_split(bio, sectors, gfp, bs)

[PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create()

2017-05-01 Thread NeilBrown
"flags" arguments are often seen as good API design as they allow easy extensibility. bioset_create_nobvec() is implemented internally as a variation in flags passed to __bioset_create(). To support future extension, make the internal structure part of the API. i.e. add a 'flags' argument to biose