Re: [PATCH 02/13] rbtree: empty nodes have no color

2012-07-10 Thread Michel Lespinasse
On Tue, Jul 10, 2012 at 3:59 AM, Daniel Santos wrote: >> One final rb_init_node() caller was recently added in sysctl code >> to implement faster sysctl name lookups. This code doesn't make use >> of RB_EMPTY_NODE at all, and from what I could see it only called >> rb_init_node() under the

Re: [PATCH 02/13] rbtree: empty nodes have no color

2012-07-10 Thread Daniel Santos
On 07/09/2012 06:35 PM, Michel Lespinasse wrote: > Empty nodes have no color. We can make use of this property to > simplify the code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE > macros. Also, we can get rid of the rb_init_node function which had > been introduced by commit

Re: [PATCH 02/13] rbtree: empty nodes have no color

2012-07-10 Thread Daniel Santos
On 07/09/2012 06:35 PM, Michel Lespinasse wrote: Empty nodes have no color. We can make use of this property to simplify the code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE macros. Also, we can get rid of the rb_init_node function which had been introduced by commit

Re: [PATCH 02/13] rbtree: empty nodes have no color

2012-07-10 Thread Michel Lespinasse
On Tue, Jul 10, 2012 at 3:59 AM, Daniel Santos danielfsan...@att.net wrote: One final rb_init_node() caller was recently added in sysctl code to implement faster sysctl name lookups. This code doesn't make use of RB_EMPTY_NODE at all, and from what I could see it only called rb_init_node()

[PATCH 02/13] rbtree: empty nodes have no color

2012-07-09 Thread Michel Lespinasse
Empty nodes have no color. We can make use of this property to simplify the code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE macros. Also, we can get rid of the rb_init_node function which had been introduced by commit 88d19cf37952a7e1e38b2bf87a00f0e857e63180 to avoid some issue with the

[PATCH 02/13] rbtree: empty nodes have no color

2012-07-09 Thread Michel Lespinasse
Empty nodes have no color. We can make use of this property to simplify the code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE macros. Also, we can get rid of the rb_init_node function which had been introduced by commit 88d19cf37952a7e1e38b2bf87a00f0e857e63180 to avoid some issue with the