Re: [PATCH 02/15] riscv: cleanup do_trap_break

2019-10-17 Thread Anup Patel
On Thu, Oct 17, 2019 at 11:07 PM Christoph Hellwig wrote: > > If we always compile the get_break_insn_length inline function we can > remove the ifdefs and let dead code elimination take care of the warn > branch that is now unreadable because the report_bug stub always > returns BUG_TRAP_TYPE_BUG

[PATCH 02/15] riscv: cleanup do_trap_break

2019-10-17 Thread Christoph Hellwig
If we always compile the get_break_insn_length inline function we can remove the ifdefs and let dead code elimination take care of the warn branch that is now unreadable because the report_bug stub always returns BUG_TRAP_TYPE_BUG. Signed-off-by: Christoph Hellwig --- arch/riscv/kernel/traps.c |