Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-28 Thread Michael Schmitz
Hello Arnd, On Thursday 27 February 2014, Michael Schmitz wrote: Arnd Bergmann wrote: Nack - the completion condition in the first hunk has its logic reversed. Try this instead (while() loops while condition true, do {} until () loops while condition false, no?) Sorry

Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-28 Thread Michael Schmitz
Hello Arnd, On Thursday 27 February 2014, Michael Schmitz wrote: Arnd Bergmann wrote: Nack - the completion condition in the first hunk has its logic reversed. Try this instead (while() loops while condition true, do {} until () loops while condition false, no?) Sorry

Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-27 Thread Arnd Bergmann
On Thursday 27 February 2014, Michael Schmitz wrote: > Arnd Bergmann wrote: > > > Nack - the completion condition in the first hunk has its logic > reversed. Try this instead (while() loops while condition true, do {} > until () loops while condition false, no?) Sorry about messing it up

Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-27 Thread Arnd Bergmann
On Thursday 27 February 2014, Michael Schmitz wrote: Arnd Bergmann wrote: Nack - the completion condition in the first hunk has its logic reversed. Try this instead (while() loops while condition true, do {} until () loops while condition false, no?) Sorry about messing it up again. I

Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-26 Thread Michael Schmitz
Arnd Bergmann wrote: sleep_on is known broken and going away. The atari_scsi driver is one of two remaining users in the falcon_get_lock() function, which is a rather crazy piece of code. This does not attempt to fix the driver's locking scheme in general, but at least prevents falcon_get_lock

[PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-26 Thread Arnd Bergmann
sleep_on is known broken and going away. The atari_scsi driver is one of two remaining users in the falcon_get_lock() function, which is a rather crazy piece of code. This does not attempt to fix the driver's locking scheme in general, but at least prevents falcon_get_lock from going to sleep when

[PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-26 Thread Arnd Bergmann
sleep_on is known broken and going away. The atari_scsi driver is one of two remaining users in the falcon_get_lock() function, which is a rather crazy piece of code. This does not attempt to fix the driver's locking scheme in general, but at least prevents falcon_get_lock from going to sleep when

Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-26 Thread Michael Schmitz
Arnd Bergmann wrote: sleep_on is known broken and going away. The atari_scsi driver is one of two remaining users in the falcon_get_lock() function, which is a rather crazy piece of code. This does not attempt to fix the driver's locking scheme in general, but at least prevents falcon_get_lock