On 5/17/19 1:08 PM, Subash Abhinov Kasiviswanathan wrote:
> On 2019-05-17 11:27, Alex Elder wrote:
. . .
>> Can you provide a good explanation about why these
>> definitions belong in "include/linux/if_rmnet.h" instead
>> of "include/soc/qcom/rmnet.h"?
>>
>> Thanks.
>>
>> -Alex
On 2019-05-17 11:27, Alex Elder wrote:
On 5/15/19 8:09 PM, Subash Abhinov Kasiviswanathan wrote:
. . .
Hi Alex
Could we instead have the rmnet header definition in
include/linux/if_rmnet.h
I have no objection to that, but I don't actually know what
the criteria are for putting a file in that
On 5/15/19 8:09 PM, Subash Abhinov Kasiviswanathan wrote:
. . .
> Hi Alex
>
> Could we instead have the rmnet header definition in
> include/linux/if_rmnet.h
I have no objection to that, but I don't actually know what
the criteria are for putting a file in that directory.
Glancing at other "if_*
+#ifndef _SOC_QCOM_RMNET_H_
+#define _SOC_QCOM_RMNET_H_
+
+#include
+
+/* Header structure that precedes packets in ETH_P_MAP protocol */
+struct rmnet_map_header {
+ u8 pad_len : 6;
+ u8 reserved_bit: 1;
+ u8 cd_bit : 1;
+ u8 mux_id;
+
On 5/15/19 1:59 AM, Arnd Bergmann wrote:
> On Sun, May 12, 2019 at 3:25 AM Alex Elder wrote:
>
>> diff --git a/include/soc/qcom/rmnet.h b/include/soc/qcom/rmnet.h
>> new file mode 100644
>> index ..80dcd6e68c3d
>> --- /dev/null
>> +++ b/include/soc/qcom/rmnet.h
>> @@ -0,0 +1,38 @@
>>
On Sun, May 12, 2019 at 3:25 AM Alex Elder wrote:
> diff --git a/include/soc/qcom/rmnet.h b/include/soc/qcom/rmnet.h
> new file mode 100644
> index ..80dcd6e68c3d
> --- /dev/null
> +++ b/include/soc/qcom/rmnet.h
> @@ -0,0 +1,38 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +/* Co
On 5/11/19 9:34 PM, Joe Perches wrote:
> On Sat, 2019-05-11 at 20:24 -0500, Alex Elder wrote:
>> include/soc/qcom/rmnet.h
>
> Should this file be added to the MAINTAINERS file
> update in patch 16/18 ?
Sure, that's a good point. I'll add it when I submit a v2.
Thank you.
On Sat, 2019-05-11 at 20:24 -0500, Alex Elder wrote:
> include/soc/qcom/rmnet.h
Should this file be added to the MAINTAINERS file
update in patch 16/18 ?
The IPA driver requires some (but not all) symbols defined in
"drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h". Create a new
public header file "include/soc/qcom/rmnet.h" and move the needed
definitions there.
Signed-off-by: Alex Elder
---
.../ethernet/qualcomm/rmnet/rmnet_handlers.c | 1 +
9 matches
Mail list logo
