Re: [PATCH 02/18] spi: stm32-spi: defer probe for reset

2020-08-07 Thread Mark Brown
On Fri, Aug 07, 2020 at 03:42:54PM +0200, Alain Volmat wrote: > On Wed, Aug 05, 2020 at 11:49:06AM +0100, Mark Brown wrote: > > On Wed, Aug 05, 2020 at 09:01:57AM +0200, Alain Volmat wrote: > > > - rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > > - if (!IS_ERR(rst)) { > > > + rst =

Re: [PATCH 02/18] spi: stm32-spi: defer probe for reset

2020-08-07 Thread Alain Volmat
On Wed, Aug 05, 2020 at 11:49:06AM +0100, Mark Brown wrote: > On Wed, Aug 05, 2020 at 09:01:57AM +0200, Alain Volmat wrote: > > > - rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > - if (!IS_ERR(rst)) { > > + rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); > >

Re: [PATCH 02/18] spi: stm32-spi: defer probe for reset

2020-08-05 Thread Mark Brown
On Wed, Aug 05, 2020 at 09:01:57AM +0200, Alain Volmat wrote: > - rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); > - if (!IS_ERR(rst)) { > + rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); > + if (rst) { > + if (IS_ERR(rst)) { > +

[PATCH 02/18] spi: stm32-spi: defer probe for reset

2020-08-05 Thread Alain Volmat
Defer the probe operation when a reset controller device is expected but have not yet been probed. This change replaces use of devm_reset_control_get_exclusive() with devm_reset_control_get_optional_exclusive() as reset controller is optional which is now explicitly stated. Signed-off-by: Alain V