Re: [PATCH 02/19] EDAC: Remove EDAC_DIMM_OFF() macro

2019-10-11 Thread Robert Richter
Thanks for review. On 11.10.19 07:09:03, Mauro Carvalho Chehab wrote: > Em Thu, 10 Oct 2019 20:25:07 + > Robert Richter escreveu: > > > The EDAC_DIMM_OFF() macro takes 5 arguments to get the DIMM's index. > > This can be much simplified now as the offset is already stored in > > struct dimm_

Re: [PATCH 02/19] EDAC: Remove EDAC_DIMM_OFF() macro

2019-10-11 Thread Mauro Carvalho Chehab
Em Thu, 10 Oct 2019 20:25:07 + Robert Richter escreveu: > The EDAC_DIMM_OFF() macro takes 5 arguments to get the DIMM's index. > This can be much simplified now as the offset is already stored in > struct dimm_info. Use it directly and completely remove the > EDAC_DIMM_OFF() macro. Ah, now I

[PATCH 02/19] EDAC: Remove EDAC_DIMM_OFF() macro

2019-10-10 Thread Robert Richter
The EDAC_DIMM_OFF() macro takes 5 arguments to get the DIMM's index. This can be much simplified now as the offset is already stored in struct dimm_info. Use it directly and completely remove the EDAC_DIMM_OFF() macro. Another advantage is that edac_mc_alloc() could be used even if the exact size