Re: [PATCH 02/21] memblock, numa: Introduce flag into memblock.

2013-07-24 Thread Tang Chen
On 07/24/2013 11:54 PM, Tejun Heo wrote: On Wed, Jul 24, 2013 at 10:53:10AM +0800, Tang Chen wrote: Let's please drop "with" and do we really need to print full 16 digits? Sure, will remove "with". But I think printing out the full flags is batter. The output seems more tidy. I mean, padding

Re: [PATCH 02/21] memblock, numa: Introduce flag into memblock.

2013-07-24 Thread Tejun Heo
On Wed, Jul 24, 2013 at 10:53:10AM +0800, Tang Chen wrote: > >Let's please drop "with" and do we really need to print full 16 > >digits? > > Sure, will remove "with". But I think printing out the full flags is batter. > The output seems more tidy. I mean, padding is fine but you can just print ou

Re: [PATCH 02/21] memblock, numa: Introduce flag into memblock.

2013-07-23 Thread Tang Chen
On 07/24/2013 03:09 AM, Tejun Heo wrote: Hello, On Fri, Jul 19, 2013 at 03:59:15PM +0800, Tang Chen wrote: +#define MEMBLK_FLAGS_DEFAULT 0x0 /* default flag */ Please don't do this. Just clearing the struct as zero is enough. @@ -439,12 +449,14 @@ repeat: int __init_memblock memblo

Re: [PATCH 02/21] memblock, numa: Introduce flag into memblock.

2013-07-23 Thread Tejun Heo
Hello, On Fri, Jul 19, 2013 at 03:59:15PM +0800, Tang Chen wrote: > +#define MEMBLK_FLAGS_DEFAULT 0x0 /* default flag */ Please don't do this. Just clearing the struct as zero is enough. > @@ -439,12 +449,14 @@ repeat: > int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t s

[PATCH 02/21] memblock, numa: Introduce flag into memblock.

2013-07-19 Thread Tang Chen
There is no flag in memblock to describe what type the memory is. Sometimes, we may use memblock to reserve some memory for special usage. And we want to know what kind of memory it is. So we need a way to differentiate memory for different usage. In hotplug environment, we want to reserve hotplug