Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Adrian Hunter
On 14/09/20 11:07 pm, Jiri Olsa wrote: > On Mon, Sep 14, 2020 at 10:08:01AM -0700, Ian Rogers wrote: > > SNIP > >>> >>> Using one of the MISC bits to resolve the union. Might actually bring >>> benefit to everyone. Us normal people get to have a smaller MMAP record, >>> while the buildid folks ca

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Adrian Hunter
On 15/09/20 1:00 am, Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 14, 2020 at 09:39:07PM +0200, Jiri Olsa escreveu: >> On Mon, Sep 14, 2020 at 12:28:41PM -0300, Arnaldo Carvalho de Melo wrote: >>> Em Mon, Sep 14, 2020 at 02:38:27PM +0900, Namhyung Kim escreveu: On Mon, Sep 14, 2020 at 6:03 AM

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Namhyung Kim
Hi Jiri, On Tue, Sep 15, 2020 at 4:38 AM Jiri Olsa wrote: > > On Mon, Sep 14, 2020 at 02:38:27PM +0900, Namhyung Kim wrote: > > SNIP > > > > diff --git a/include/uapi/linux/perf_event.h > > > b/include/uapi/linux/perf_event.h > > > index 077e7ee69e3d..facfc3c673ed 100644 > > > --- a/include/uapi

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Ian Rogers
On Mon, Sep 14, 2020 at 10:26 AM Stephane Eranian wrote: > > On Mon, Sep 14, 2020 at 2:08 AM wrote: > > > > On Sun, Sep 13, 2020 at 11:41:00PM -0700, Stephane Eranian wrote: > > > On Sun, Sep 13, 2020 at 2:03 PM Jiri Olsa wrote: > > > what happens if I set mmap3 and mmap2? > > > > > > I think us

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2020 at 09:50:45PM +0200, Jiri Olsa escreveu: > On Mon, Sep 14, 2020 at 12:31:34PM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > > > --- > > > > include/uapi/linux/perf_event.h | 27 ++- > > > > kernel/events/core.c| 38

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2020 at 09:39:07PM +0200, Jiri Olsa escreveu: > On Mon, Sep 14, 2020 at 12:28:41PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Sep 14, 2020 at 02:38:27PM +0900, Namhyung Kim escreveu: > > > On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > > > Add new version of mmap even

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 10:08:01AM -0700, Ian Rogers wrote: SNIP > > > > Using one of the MISC bits to resolve the union. Might actually bring > > benefit to everyone. Us normal people get to have a smaller MMAP record, > > while the buildid folks can have it too. > > > > Even more extreme would

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 10:26:05AM -0700, Stephane Eranian wrote: > On Mon, Sep 14, 2020 at 2:08 AM wrote: > > > > On Sun, Sep 13, 2020 at 11:41:00PM -0700, Stephane Eranian wrote: > > > On Sun, Sep 13, 2020 at 2:03 PM Jiri Olsa wrote: > > > what happens if I set mmap3 and mmap2? > > > > > > I th

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 12:31:34PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > > --- > > > include/uapi/linux/perf_event.h | 27 ++- > > > kernel/events/core.c| 38 +++-- > > > 2 files changed, 57 insertions(+), 8 deletions(-) > > >

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Jiri Olsa
On Sun, Sep 13, 2020 at 11:41:00PM -0700, Stephane Eranian wrote: > On Sun, Sep 13, 2020 at 2:03 PM Jiri Olsa wrote: > > > > Add new version of mmap event. The MMAP3 record is an > > augmented version of MMAP2, it adds build id value to > > identify the exact binary object behind memory map: > > >

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 06:35:34PM +0200, pet...@infradead.org wrote: > On Mon, Sep 14, 2020 at 12:28:41PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > struct { > > > > struct perf_event_header header; > > > > > > u32 pid, tid; > > > > u64

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Jiri Olsa
On Sun, Sep 13, 2020 at 11:20:31PM -0700, Song Liu wrote: > On Sun, Sep 13, 2020 at 10:40 PM Namhyung Kim wrote: > > > > On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > > > > > Add new version of mmap event. The MMAP3 record is an > > > augmented version of MMAP2, it adds build id value to >

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 02:38:27PM +0900, Namhyung Kim wrote: SNIP > > diff --git a/include/uapi/linux/perf_event.h > > b/include/uapi/linux/perf_event.h > > index 077e7ee69e3d..facfc3c673ed 100644 > > --- a/include/uapi/linux/perf_event.h > > +++ b/include/uapi/linux/perf_event.h > > @@ -384,7

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 12:28:41PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 14, 2020 at 02:38:27PM +0900, Namhyung Kim escreveu: > > On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > > Add new version of mmap event. The MMAP3 record is an > > > augmented version of MMAP2, it adds bu

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Stephane Eranian
On Mon, Sep 14, 2020 at 2:08 AM wrote: > > On Sun, Sep 13, 2020 at 11:41:00PM -0700, Stephane Eranian wrote: > > On Sun, Sep 13, 2020 at 2:03 PM Jiri Olsa wrote: > > what happens if I set mmap3 and mmap2? > > > > I think using mmap3 for every mmap may be overkill as you add useless > > 20 bytes t

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Ian Rogers
On Mon, Sep 14, 2020 at 9:35 AM wrote: > > On Mon, Sep 14, 2020 at 12:28:41PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > struct { > > > > struct perf_event_header header; > > > > > > u32 pid, tid; > > > > u64 addr; > > > > u64

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread peterz
On Mon, Sep 14, 2020 at 12:28:41PM -0300, Arnaldo Carvalho de Melo wrote: > > > struct { > > > struct perf_event_header header; > > > > u32 pid, tid; > > > u64 addr; > > > u64 len; > > > u64

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2020 at 11:08:11AM +0200, pet...@infradead.org escreveu: > On Sun, Sep 13, 2020 at 11:41:00PM -0700, Stephane Eranian wrote: > > On Sun, Sep 13, 2020 at 2:03 PM Jiri Olsa wrote: > > what happens if I set mmap3 and mmap2? > > > > I think using mmap3 for every mmap may be overkill a

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 13, 2020 at 11:41:00PM -0700, Stephane Eranian escreveu: > On Sun, Sep 13, 2020 at 2:03 PM Jiri Olsa wrote: > > > > Add new version of mmap event. The MMAP3 record is an > > augmented version of MMAP2, it adds build id value to > > identify the exact binary object behind memory map: >

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2020 at 02:38:27PM +0900, Namhyung Kim escreveu: > On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > Add new version of mmap event. The MMAP3 record is an > > augmented version of MMAP2, it adds build id value to > > identify the exact binary object behind memory map: > > str

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread peterz
On Sun, Sep 13, 2020 at 11:02:49PM +0200, Jiri Olsa wrote: > Add new version of mmap event. The MMAP3 record is an > augmented version of MMAP2, it adds build id value to > identify the exact binary object behind memory map: > > struct { > struct perf_event_header header; > > u32

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-14 Thread peterz
On Sun, Sep 13, 2020 at 11:41:00PM -0700, Stephane Eranian wrote: > On Sun, Sep 13, 2020 at 2:03 PM Jiri Olsa wrote: > what happens if I set mmap3 and mmap2? > > I think using mmap3 for every mmap may be overkill as you add useless > 20 bytes to an mmap record. > I am not sure if your code handle

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-13 Thread Stephane Eranian
On Sun, Sep 13, 2020 at 2:03 PM Jiri Olsa wrote: > > Add new version of mmap event. The MMAP3 record is an > augmented version of MMAP2, it adds build id value to > identify the exact binary object behind memory map: > > struct { > struct perf_event_header header; > > u32

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-13 Thread Song Liu
On Sun, Sep 13, 2020 at 10:40 PM Namhyung Kim wrote: > > On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > > > Add new version of mmap event. The MMAP3 record is an > > augmented version of MMAP2, it adds build id value to > > identify the exact binary object behind memory map: > > > > struc

Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-13 Thread Namhyung Kim
On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > Add new version of mmap event. The MMAP3 record is an > augmented version of MMAP2, it adds build id value to > identify the exact binary object behind memory map: > > struct { > struct perf_event_header header; > > u32

[PATCH 02/26] perf: Introduce mmap3 version of mmap event

2020-09-13 Thread Jiri Olsa
Add new version of mmap event. The MMAP3 record is an augmented version of MMAP2, it adds build id value to identify the exact binary object behind memory map: struct { struct perf_event_header header; u32 pid, tid; u64 addr; u64