Re: [PATCH 02/31] perf tools: Don't set cmdline_group_boundary if no evsel is collected

2015-09-01 Thread Wangnan (F)
On 2015/9/1 18:38, Jiri Olsa wrote: On Mon, Aug 31, 2015 at 04:20:03PM -0300, Arnaldo Carvalho de Melo wrote: Em Sat, Aug 29, 2015 at 04:21:36AM +, Wang Nan escreveu: If parse_events__scanner() collects no entry, perf_evlist__last(evlist) is invalid. Then setting of cmdline_group_boundary

Re: [PATCH 02/31] perf tools: Don't set cmdline_group_boundary if no evsel is collected

2015-09-01 Thread Wangnan (F)
On 2015/9/1 3:20, Arnaldo Carvalho de Melo wrote: Em Sat, Aug 29, 2015 at 04:21:36AM +, Wang Nan escreveu: If parse_events__scanner() collects no entry, perf_evlist__last(evlist) is invalid. Then setting of cmdline_group_boundary touches invalid. It could happend in currect BPF implementa

Re: [PATCH 02/31] perf tools: Don't set cmdline_group_boundary if no evsel is collected

2015-09-01 Thread Jiri Olsa
On Mon, Aug 31, 2015 at 04:20:03PM -0300, Arnaldo Carvalho de Melo wrote: > Em Sat, Aug 29, 2015 at 04:21:36AM +, Wang Nan escreveu: > > If parse_events__scanner() collects no entry, perf_evlist__last(evlist) > > is invalid. Then setting of cmdline_group_boundary touches invalid. > > > > It co

Re: [PATCH 02/31] perf tools: Don't set cmdline_group_boundary if no evsel is collected

2015-08-31 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 29, 2015 at 04:21:36AM +, Wang Nan escreveu: > If parse_events__scanner() collects no entry, perf_evlist__last(evlist) > is invalid. Then setting of cmdline_group_boundary touches invalid. > > It could happend in currect BPF implementation. See [1]. Although it > can be fixed, for

[PATCH 02/31] perf tools: Don't set cmdline_group_boundary if no evsel is collected

2015-08-28 Thread Wang Nan
If parse_events__scanner() collects no entry, perf_evlist__last(evlist) is invalid. Then setting of cmdline_group_boundary touches invalid. It could happend in currect BPF implementation. See [1]. Although it can be fixed, for safety reason it whould be better to introduce this check. Instead of