Re: [PATCH 02/46] kernel: Add prototype definition to include/linux/kernel.h

2014-02-27 Thread Steven Rostedt
[ Dropped Chen Gang, Tony Lu, Chris Metcalf and Robin Holt as their emails are bouncing for me ] On Thu, 27 Feb 2014 08:43:36 -0800 Josh Triplett wrote: > > > +void __weak panic_smp_self_stop(void); > > > > Is __weak required in a prototype? What about the override that is not > > weak. > >

Re: [PATCH 02/46] kernel: Add prototype definition to include/linux/kernel.h

2014-02-27 Thread Josh Triplett
On Thu, Feb 27, 2014 at 11:32:30AM -0500, Steven Rostedt wrote: > On Thu, 27 Feb 2014 16:38:50 +0530 > Rashika Kheria wrote: > > Add prototype declaration to header file include/linux/kernel.h because > > it is used by more than one file. > > > > This also eliminates the following warning in kern

Re: [PATCH 02/46] kernel: Add prototype definition to include/linux/kernel.h

2014-02-27 Thread Steven Rostedt
On Thu, 27 Feb 2014 16:38:50 +0530 Rashika Kheria wrote: > Add prototype declaration to header file include/linux/kernel.h because > it is used by more than one file. > > This also eliminates the following warning in kernel/panic.c: > kernel/panic.c:55:13: warning: no previous prototype for > ‘

[PATCH 02/46] kernel: Add prototype definition to include/linux/kernel.h

2014-02-27 Thread Rashika Kheria
Add prototype declaration to header file include/linux/kernel.h because it is used by more than one file. This also eliminates the following warning in kernel/panic.c: kernel/panic.c:55:13: warning: no previous prototype for ‘panic_smp_self_stop’ [-Wmissing-prototypes] Signed-off-by: Rashika Khe