Re: [PATCH 02/47] Add new driver files for Artpec-3.

2007-12-14 Thread Jesper Nilsson
On Thu, Dec 13, 2007 at 02:30:33PM -0800, David Brownell wrote: > This is needlessly arch-specific though... some other recent platform updates > have provided the Documentation/gpio.txt interfaces and plan to update them > to use the new gpiolib infrastructure when that hits mainline. That gives

Re: [PATCH 02/47] Add new driver files for Artpec-3.

2007-12-14 Thread Jesper Nilsson
On Thu, Dec 13, 2007 at 02:30:33PM -0800, David Brownell wrote: This is needlessly arch-specific though... some other recent platform updates have provided the Documentation/gpio.txt interfaces and plan to update them to use the new gpiolib infrastructure when that hits mainline. That gives a

Re: [PATCH 02/47] Add new driver files for Artpec-3.

2007-12-13 Thread David Brownell
This is needlessly arch-specific though... some other recent platform updates have provided the Documentation/gpio.txt interfaces and plan to update them to use the new gpiolib infrastructure when that hits mainline. That gives a simpler and more extensible approach to I2C (or SPI, etc) GPIO

Re: [PATCH 02/47] Add new driver files for Artpec-3.

2007-12-13 Thread David Brownell
This is needlessly arch-specific though... some other recent platform updates have provided the Documentation/gpio.txt interfaces and plan to update them to use the new gpiolib infrastructure when that hits mainline. That gives a simpler and more extensible approach to I2C (or SPI, etc) GPIO

Re: [PATCH 02/47] Add new driver files for Artpec-3.

2007-12-12 Thread Andrew Morton
On Thu, 29 Nov 2007 17:03:41 +0100 Jesper Nilsson <[EMAIL PROTECTED]> wrote: > Adds gpio and nandflash handling for Artpec-3. > > ... > > +static volatile unsigned long *data_out[NUM_PORTS] = { all these volatiles really shouldn't be here. > +static void > +gpio_set_alarm(struct gpio_private

Re: [PATCH 02/47] Add new driver files for Artpec-3.

2007-12-12 Thread Andrew Morton
On Thu, 29 Nov 2007 17:03:41 +0100 Jesper Nilsson [EMAIL PROTECTED] wrote: Adds gpio and nandflash handling for Artpec-3. ... +static volatile unsigned long *data_out[NUM_PORTS] = { all these volatiles really shouldn't be here. +static void +gpio_set_alarm(struct gpio_private *priv) +{

[PATCH 02/47] Add new driver files for Artpec-3.

2007-12-06 Thread Jesper Nilsson
Adds gpio and nandflash handling for Artpec-3. Signed-off-by: Jesper Nilsson <[EMAIL PROTECTED]> --- arch/cris/arch-v32/drivers/mach-a3/Makefile|6 + arch/cris/arch-v32/drivers/mach-a3/gpio.c | 984 arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 178

[PATCH 02/47] Add new driver files for Artpec-3.

2007-12-06 Thread Jesper Nilsson
Adds gpio and nandflash handling for Artpec-3. Signed-off-by: Jesper Nilsson [EMAIL PROTECTED] --- arch/cris/arch-v32/drivers/mach-a3/Makefile|6 + arch/cris/arch-v32/drivers/mach-a3/gpio.c | 984 arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 178 +