Re: [PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-15 Thread gregkh
On Fri, Sep 14, 2018 at 09:38:52PM +0200, Arnd Bergmann wrote: > On Fri, Sep 14, 2018 at 8:17 PM gregkh wrote: > > > > On Fri, Sep 14, 2018 at 05:15:52PM +0200, Arnd Bergmann wrote: > > > On Thu, Sep 13, 2018 at 4:40 AM Al Viro wrote: > > > > + case TCSETX: > > > + case TCSETXF: > >

Re: [PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-15 Thread gregkh
On Fri, Sep 14, 2018 at 09:38:52PM +0200, Arnd Bergmann wrote: > On Fri, Sep 14, 2018 at 8:17 PM gregkh wrote: > > > > On Fri, Sep 14, 2018 at 05:15:52PM +0200, Arnd Bergmann wrote: > > > On Thu, Sep 13, 2018 at 4:40 AM Al Viro wrote: > > > > + case TCSETX: > > > + case TCSETXF: > >

Re: [PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-14 Thread Arnd Bergmann
On Fri, Sep 14, 2018 at 8:17 PM gregkh wrote: > > On Fri, Sep 14, 2018 at 05:15:52PM +0200, Arnd Bergmann wrote: > > On Thu, Sep 13, 2018 at 4:40 AM Al Viro wrote: > > + case TCSETX: > > + case TCSETXF: > > + case TCSETXW: > > + case TIOCGETC: > > + case TIOCGETP:

Re: [PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-14 Thread Arnd Bergmann
On Fri, Sep 14, 2018 at 8:17 PM gregkh wrote: > > On Fri, Sep 14, 2018 at 05:15:52PM +0200, Arnd Bergmann wrote: > > On Thu, Sep 13, 2018 at 4:40 AM Al Viro wrote: > > + case TCSETX: > > + case TCSETXF: > > + case TCSETXW: > > + case TIOCGETC: > > + case TIOCGETP:

Re: [PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-14 Thread gregkh
On Fri, Sep 14, 2018 at 05:15:52PM +0200, Arnd Bergmann wrote: > On Thu, Sep 13, 2018 at 4:40 AM Al Viro wrote: > > > > From: Al Viro > > > > ioctls that are > > * callable only via tty_ioctl() > > * not driver-specific > > * not demand data structure conversions > >

Re: [PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-14 Thread gregkh
On Fri, Sep 14, 2018 at 05:15:52PM +0200, Arnd Bergmann wrote: > On Thu, Sep 13, 2018 at 4:40 AM Al Viro wrote: > > > > From: Al Viro > > > > ioctls that are > > * callable only via tty_ioctl() > > * not driver-specific > > * not demand data structure conversions > >

Re: [PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-14 Thread Arnd Bergmann
On Thu, Sep 13, 2018 at 4:40 AM Al Viro wrote: > > From: Al Viro > > ioctls that are > * callable only via tty_ioctl() > * not driver-specific > * not demand data structure conversions > * either always need passing arg as is or always demand compat_ptr() > get

Re: [PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-14 Thread Arnd Bergmann
On Thu, Sep 13, 2018 at 4:40 AM Al Viro wrote: > > From: Al Viro > > ioctls that are > * callable only via tty_ioctl() > * not driver-specific > * not demand data structure conversions > * either always need passing arg as is or always demand compat_ptr() > get

[PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-12 Thread Al Viro
From: Al Viro ioctls that are * callable only via tty_ioctl() * not driver-specific * not demand data structure conversions * either always need passing arg as is or always demand compat_ptr() get intercepted in tty_compat_ioctl() from the very beginning and

[PATCH 02/50] move compat handling of tty ioctls to tty_compat_ioctl()

2018-09-12 Thread Al Viro
From: Al Viro ioctls that are * callable only via tty_ioctl() * not driver-specific * not demand data structure conversions * either always need passing arg as is or always demand compat_ptr() get intercepted in tty_compat_ioctl() from the very beginning and