Re: [PATCH 03/10] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Ricardo Ribalda Delgado
Hi Laurent On Thu, Mar 11, 2021 at 4:59 PM Laurent Pinchart wrote: > > Hi Ricardo, > > Thank you for the patch. > > On Thu, Mar 11, 2021 at 03:08:22PM +0100, Ricardo Ribalda wrote: > > As discussed in the IRC with Hans > > > > We need to specify in the commit message that this is most likely due

Re: [PATCH 03/10] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Thu, Mar 11, 2021 at 03:08:22PM +0100, Ricardo Ribalda wrote: > As discussed in the IRC with Hans > > We need to specify in the commit message that this is most likely due > to hw error. > > On Thu, Mar 11, 2021 at 1:20 PM Ricardo Ribalda wrote: > > > >

Re: [PATCH 03/10] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Hans Verkuil
On 11/03/2021 13:20, Ricardo Ribalda wrote: > Fixes v4l2-compliance: > > Control ioctls (Input 0): > fail: v4l2-test-controls.cpp(448): s_ctrl returned an error > (22) > test VIDIOC_G/S_CTRL: FAIL > fail: v4l2-test-controls.cpp(698): s_ext_ctrls returned an

Re: [PATCH 03/10] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Ricardo Ribalda
As discussed in the IRC with Hans We need to specify in the commit message that this is most likely due to hw error. On Thu, Mar 11, 2021 at 1:20 PM Ricardo Ribalda wrote: > > Fixes v4l2-compliance: > > Control ioctls (Input 0): > fail: v4l2-test-controls.cpp(448): s_ctrl returne

[PATCH 03/10] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Ricardo Ribalda
Fixes v4l2-compliance: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(448): s_ctrl returned an error (22) test VIDIOC_G/S_CTRL: FAIL fail: v4l2-test-controls.cpp(698): s_ext_ctrls returned an error (22) test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL S