Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread arvindY
On Monday 04 December 2017 10:12 PM, Russell King - ARM Linux wrote: On Mon, Dec 04, 2017 at 11:34:48AM -0500, David Miller wrote: From: Russell King - ARM Linux Date: Mon, 4 Dec 2017 16:24:47 + On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: From:

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread arvindY
On Monday 04 December 2017 10:12 PM, Russell King - ARM Linux wrote: On Mon, Dec 04, 2017 at 11:34:48AM -0500, David Miller wrote: From: Russell King - ARM Linux Date: Mon, 4 Dec 2017 16:24:47 + On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: From: Arvind Yadav Date:

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread Russell King - ARM Linux
On Mon, Dec 04, 2017 at 11:34:48AM -0500, David Miller wrote: > From: Russell King - ARM Linux > Date: Mon, 4 Dec 2017 16:24:47 + > > > On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: > >> From: Arvind Yadav > >> Date: Sun, 3

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread Russell King - ARM Linux
On Mon, Dec 04, 2017 at 11:34:48AM -0500, David Miller wrote: > From: Russell King - ARM Linux > Date: Mon, 4 Dec 2017 16:24:47 + > > > On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: > >> From: Arvind Yadav > >> Date: Sun, 3 Dec 2017 00:56:15 +0530 > >> > >> > The

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread David Miller
From: Russell King - ARM Linux Date: Mon, 4 Dec 2017 16:24:47 + > On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: >> From: Arvind Yadav >> Date: Sun, 3 Dec 2017 00:56:15 +0530 >> >> > The platform_get_irq() function returns

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread David Miller
From: Russell King - ARM Linux Date: Mon, 4 Dec 2017 16:24:47 + > On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: >> From: Arvind Yadav >> Date: Sun, 3 Dec 2017 00:56:15 +0530 >> >> > The platform_get_irq() function returns negative if an error occurs. >> > zero or positive

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread Russell King - ARM Linux
On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: > From: Arvind Yadav > Date: Sun, 3 Dec 2017 00:56:15 +0530 > > > The platform_get_irq() function returns negative if an error occurs. > > zero or positive number on success. platform_get_irq() error

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread Russell King - ARM Linux
On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: > From: Arvind Yadav > Date: Sun, 3 Dec 2017 00:56:15 +0530 > > > The platform_get_irq() function returns negative if an error occurs. > > zero or positive number on success. platform_get_irq() error checking > > for zero is not

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread David Miller
From: Arvind Yadav Date: Sun, 3 Dec 2017 00:56:15 +0530 > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. And remove unnecessary check for

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread David Miller
From: Arvind Yadav Date: Sun, 3 Dec 2017 00:56:15 +0530 > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. And remove unnecessary check for free_netdev(). > > Signed-off-by:

[PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-02 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. And remove unnecessary check for free_netdev(). Signed-off-by: Arvind Yadav ---

[PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-02 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. And remove unnecessary check for free_netdev(). Signed-off-by: Arvind Yadav --- drivers/net/ethernet/ezchip/nps_enet.c | 7 +++