Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-04-05 Thread KOSAKI Motohiro
(3/27/13 9:00 AM), Michal Hocko wrote: > On Tue 26-03-13 16:35:35, Naoya Horiguchi wrote: > [...] >> The differences is that migrate_huge_page() has one hugepage as an argument, >> and migrate_pages() has a pagelist with multiple hugepages. >> I already told this before and I'm not sure it's

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-04-05 Thread KOSAKI Motohiro
(3/27/13 9:00 AM), Michal Hocko wrote: On Tue 26-03-13 16:35:35, Naoya Horiguchi wrote: [...] The differences is that migrate_huge_page() has one hugepage as an argument, and migrate_pages() has a pagelist with multiple hugepages. I already told this before and I'm not sure it's enough to

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-04-02 Thread Michal Hocko
On Mon 01-04-13 10:43:14, Aneesh Kumar K.V wrote: > Michal Hocko writes: > > > On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: > >> Naoya Horiguchi writes: > > [...] > >> > diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c > >> > index df0694c..4e01082 100644 > >> >

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-04-02 Thread Michal Hocko
On Mon 01-04-13 10:43:14, Aneesh Kumar K.V wrote: Michal Hocko mho...@suse.cz writes: On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: Naoya Horiguchi n-horigu...@ah.jp.nec.com writes: [...] diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c index

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-31 Thread Aneesh Kumar K.V
Michal Hocko writes: > On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: >> Naoya Horiguchi writes: > [...] >> > diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c >> > index df0694c..4e01082 100644 >> > --- v3.9-rc3.orig/mm/memory-failure.c >> > +++

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-31 Thread Aneesh Kumar K.V
Michal Hocko mho...@suse.cz writes: On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: Naoya Horiguchi n-horigu...@ah.jp.nec.com writes: [...] diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c index df0694c..4e01082 100644 --- v3.9-rc3.orig/mm/memory-failure.c

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page() (fwd)

2013-03-29 Thread Michal Hocko
Forwarding off-list email On Fri 29-03-13 18:24:01, Aneesh Kumar K.V wrote: > Michal Hocko writes: > > > On Fri 29-03-13 10:56:00, Aneesh Kumar K.V wrote: > >> Michal Hocko writes: > > [...] > >> > Little bit offtopic: > >> > Btw. hugetlb migration breaks to charging even before this patchset

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-29 Thread Michal Hocko
On Fri 29-03-13 10:56:00, Aneesh Kumar K.V wrote: > Michal Hocko writes: [...] > > Little bit offtopic: > > Btw. hugetlb migration breaks to charging even before this patchset > > AFAICS. The above put_page should remove the last reference and then it > > will uncharge it but I do not see

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-29 Thread Michal Hocko
On Fri 29-03-13 10:56:00, Aneesh Kumar K.V wrote: Michal Hocko mho...@suse.cz writes: [...] Little bit offtopic: Btw. hugetlb migration breaks to charging even before this patchset AFAICS. The above put_page should remove the last reference and then it will uncharge it but I do not see

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page() (fwd)

2013-03-29 Thread Michal Hocko
Forwarding off-list email On Fri 29-03-13 18:24:01, Aneesh Kumar K.V wrote: Michal Hocko mho...@suse.cz writes: On Fri 29-03-13 10:56:00, Aneesh Kumar K.V wrote: Michal Hocko mho...@suse.cz writes: [...] Little bit offtopic: Btw. hugetlb migration breaks to charging even before

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-28 Thread Aneesh Kumar K.V
Michal Hocko writes: > On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: >> Naoya Horiguchi writes: > [...] >> > diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c >> > index df0694c..4e01082 100644 >> > --- v3.9-rc3.orig/mm/memory-failure.c >> > +++

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-28 Thread Michal Hocko
On Wed 27-03-13 15:19:24, Naoya Horiguchi wrote: > On Wed, Mar 27, 2013 at 02:52:50PM +0100, Michal Hocko wrote: > > On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: > > > Naoya Horiguchi writes: > > [...] > > > > diff --git v3.9-rc3.orig/mm/memory-failure.c > > > > v3.9-rc3/mm/memory-failure.c

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-28 Thread Aneesh Kumar K.V
Michal Hocko mho...@suse.cz writes: On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: Naoya Horiguchi n-horigu...@ah.jp.nec.com writes: [...] diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c index df0694c..4e01082 100644 --- v3.9-rc3.orig/mm/memory-failure.c

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-28 Thread Michal Hocko
On Wed 27-03-13 15:19:24, Naoya Horiguchi wrote: On Wed, Mar 27, 2013 at 02:52:50PM +0100, Michal Hocko wrote: On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: Naoya Horiguchi n-horigu...@ah.jp.nec.com writes: [...] diff --git v3.9-rc3.orig/mm/memory-failure.c

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-27 Thread Naoya Horiguchi
On Wed, Mar 27, 2013 at 02:52:50PM +0100, Michal Hocko wrote: > On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: > > Naoya Horiguchi writes: > [...] > > > diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c > > > index df0694c..4e01082 100644 > > > ---

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-27 Thread Michal Hocko
On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: > Naoya Horiguchi writes: [...] > > diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c > > index df0694c..4e01082 100644 > > --- v3.9-rc3.orig/mm/memory-failure.c > > +++ v3.9-rc3/mm/memory-failure.c > > @@ -1467,6 +1467,7

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-27 Thread Michal Hocko
On Tue 26-03-13 16:35:35, Naoya Horiguchi wrote: [...] > The differences is that migrate_huge_page() has one hugepage as an argument, > and migrate_pages() has a pagelist with multiple hugepages. > I already told this before and I'm not sure it's enough to answer the > question, > so I explain

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-27 Thread Michal Hocko
On Tue 26-03-13 16:35:35, Naoya Horiguchi wrote: [...] The differences is that migrate_huge_page() has one hugepage as an argument, and migrate_pages() has a pagelist with multiple hugepages. I already told this before and I'm not sure it's enough to answer the question, so I explain another

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-27 Thread Michal Hocko
On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: Naoya Horiguchi n-horigu...@ah.jp.nec.com writes: [...] diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c index df0694c..4e01082 100644 --- v3.9-rc3.orig/mm/memory-failure.c +++ v3.9-rc3/mm/memory-failure.c @@

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-27 Thread Naoya Horiguchi
On Wed, Mar 27, 2013 at 02:52:50PM +0100, Michal Hocko wrote: On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote: Naoya Horiguchi n-horigu...@ah.jp.nec.com writes: [...] diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c index df0694c..4e01082 100644 ---

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-26 Thread Naoya Horiguchi
On Tue, Mar 26, 2013 at 10:49:50AM +0100, Michal Hocko wrote: > On Tue 26-03-13 00:34:40, Naoya Horiguchi wrote: > > On Mon, Mar 25, 2013 at 01:31:28PM +0100, Michal Hocko wrote: > > > On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: > [...] > > > > @@ -1482,12 +1483,20 @@ static int

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-26 Thread Aneesh Kumar K.V
Naoya Horiguchi writes: > Currently migrate_huge_page() takes a pointer to a hugepage to be > migrated as an argument, instead of taking a pointer to the list of > hugepages to be migrated. This behavior was introduced in commit > 189ebff28 ("hugetlb: simplify migrate_huge_page()"), and was OK >

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-26 Thread Michal Hocko
On Tue 26-03-13 00:34:40, Naoya Horiguchi wrote: > On Mon, Mar 25, 2013 at 01:31:28PM +0100, Michal Hocko wrote: > > On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: [...] > > > @@ -1482,12 +1483,20 @@ static int soft_offline_huge_page(struct page > > > *page, int flags) > > >

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-26 Thread Michal Hocko
On Tue 26-03-13 00:34:40, Naoya Horiguchi wrote: On Mon, Mar 25, 2013 at 01:31:28PM +0100, Michal Hocko wrote: On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: [...] @@ -1482,12 +1483,20 @@ static int soft_offline_huge_page(struct page *page, int flags) unlock_page(hpage);

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-26 Thread Aneesh Kumar K.V
Naoya Horiguchi n-horigu...@ah.jp.nec.com writes: Currently migrate_huge_page() takes a pointer to a hugepage to be migrated as an argument, instead of taking a pointer to the list of hugepages to be migrated. This behavior was introduced in commit 189ebff28 (hugetlb: simplify

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-26 Thread Naoya Horiguchi
On Tue, Mar 26, 2013 at 10:49:50AM +0100, Michal Hocko wrote: On Tue 26-03-13 00:34:40, Naoya Horiguchi wrote: On Mon, Mar 25, 2013 at 01:31:28PM +0100, Michal Hocko wrote: On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: [...] @@ -1482,12 +1483,20 @@ static int

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-25 Thread Naoya Horiguchi
On Mon, Mar 25, 2013 at 01:31:28PM +0100, Michal Hocko wrote: > On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: > > Currently migrate_huge_page() takes a pointer to a hugepage to be > > migrated as an argument, instead of taking a pointer to the list of > > hugepages to be migrated. This behavior

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-25 Thread Michal Hocko
On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: > Currently migrate_huge_page() takes a pointer to a hugepage to be > migrated as an argument, instead of taking a pointer to the list of > hugepages to be migrated. This behavior was introduced in commit > 189ebff28 ("hugetlb: simplify

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-25 Thread Michal Hocko
On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: Currently migrate_huge_page() takes a pointer to a hugepage to be migrated as an argument, instead of taking a pointer to the list of hugepages to be migrated. This behavior was introduced in commit 189ebff28 (hugetlb: simplify

Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-25 Thread Naoya Horiguchi
On Mon, Mar 25, 2013 at 01:31:28PM +0100, Michal Hocko wrote: On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: Currently migrate_huge_page() takes a pointer to a hugepage to be migrated as an argument, instead of taking a pointer to the list of hugepages to be migrated. This behavior was

[PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-22 Thread Naoya Horiguchi
Currently migrate_huge_page() takes a pointer to a hugepage to be migrated as an argument, instead of taking a pointer to the list of hugepages to be migrated. This behavior was introduced in commit 189ebff28 ("hugetlb: simplify migrate_huge_page()"), and was OK because until now hugepage

[PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()

2013-03-22 Thread Naoya Horiguchi
Currently migrate_huge_page() takes a pointer to a hugepage to be migrated as an argument, instead of taking a pointer to the list of hugepages to be migrated. This behavior was introduced in commit 189ebff28 (hugetlb: simplify migrate_huge_page()), and was OK because until now hugepage migration