Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

Miklos Szeredi writes: > On Fri, Dec 22, 2017 at 3:32 PM, Dongsu Park wrote: >> From: Eric W. Biederman >> >> Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to >> chown files. Ordinarily the

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

Miklos Szeredi writes: > On Fri, Dec 22, 2017 at 3:32 PM, Dongsu Park wrote: >> From: Eric W. Biederman >> >> Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to >> chown files. Ordinarily the capable_wrt_inode_uidgid check is >> sufficient to allow access to files but when

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

On Fri, Dec 22, 2017 at 3:32 PM, Dongsu Park wrote: > From: Eric W. Biederman > > Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to > chown files. Ordinarily the capable_wrt_inode_uidgid check is > sufficient to allow access to files

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

On Fri, Dec 22, 2017 at 3:32 PM, Dongsu Park wrote: > From: Eric W. Biederman > > Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to > chown files. Ordinarily the capable_wrt_inode_uidgid check is > sufficient to allow access to files but when the underlying filesystem > has

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

On Tue, Jan 09, 2018 at 04:10:54PM +0100, Dongsu Park wrote: > On Fri, Jan 5, 2018 at 8:24 PM, Luis R. Rodriguez wrote: > > On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > > I think this patch would read much better and easier to review if it was > > split up by

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

On Tue, Jan 09, 2018 at 04:10:54PM +0100, Dongsu Park wrote: > On Fri, Jan 5, 2018 at 8:24 PM, Luis R. Rodriguez wrote: > > On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > > I think this patch would read much better and easier to review if it was > > split up by first adding the

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

Hi, On Fri, Jan 5, 2018 at 8:24 PM, Luis R. Rodriguez wrote: > On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: >> diff --git a/fs/attr.c b/fs/attr.c >> index 12ffdb6f..bf8e94f3 100644 >> --- a/fs/attr.c >> +++ b/fs/attr.c >> @@ -18,6 +18,30 @@ >> #include >>

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

Hi, On Fri, Jan 5, 2018 at 8:24 PM, Luis R. Rodriguez wrote: > On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: >> diff --git a/fs/attr.c b/fs/attr.c >> index 12ffdb6f..bf8e94f3 100644 >> --- a/fs/attr.c >> +++ b/fs/attr.c >> @@ -18,6 +18,30 @@ >> #include >> #include >> >>

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > diff --git a/fs/attr.c b/fs/attr.c > index 12ffdb6f..bf8e94f3 100644 > --- a/fs/attr.c > +++ b/fs/attr.c > @@ -18,6 +18,30 @@ > #include > #include > > +static bool chown_ok(const struct inode *inode, kuid_t uid) > +{ > + if

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > diff --git a/fs/attr.c b/fs/attr.c > index 12ffdb6f..bf8e94f3 100644 > --- a/fs/attr.c > +++ b/fs/attr.c > @@ -18,6 +18,30 @@ > #include > #include > > +static bool chown_ok(const struct inode *inode, kuid_t uid) > +{ > + if

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > From: Eric W. Biederman > > Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to Note it is CAP_CHOWN > chown files. Ordinarily the capable_wrt_inode_uidgid check is > sufficient to allow

Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > From: Eric W. Biederman > > Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to Note it is CAP_CHOWN > chown files. Ordinarily the capable_wrt_inode_uidgid check is > sufficient to allow access to files but when

[PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

From: Eric W. Biederman Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to chown files. Ordinarily the capable_wrt_inode_uidgid check is sufficient to allow access to files but when the underlying filesystem has uids or gids that don't map to the

[PATCH 03/11] fs: Allow superblock owner to change ownership of inodes

From: Eric W. Biederman Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to chown files. Ordinarily the capable_wrt_inode_uidgid check is sufficient to allow access to files but when the underlying filesystem has uids or gids that don't map to the current user namespace it is