Re: [PATCH 03/11] powerpc: Drop unused syscall_get_error()

2015-07-27 Thread Kees Cook
On Thu, Jul 23, 2015 at 3:21 AM, Michael Ellerman wrote: > syscall_get_error() is unused, and never has been. > > It's also probably wrong, as it negates r3 before returning it, but that > depends on what the caller is expecting. > > It also doesn't deal with compat, and doesn't deal with TIF_NOER

[PATCH 03/11] powerpc: Drop unused syscall_get_error()

2015-07-23 Thread Michael Ellerman
syscall_get_error() is unused, and never has been. It's also probably wrong, as it negates r3 before returning it, but that depends on what the caller is expecting. It also doesn't deal with compat, and doesn't deal with TIF_NOERROR. Although we could fix those, until it has a caller and it's cl