Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-28 Thread Peter Zijlstra
On Thu, Feb 28, 2019 at 10:59:19AM -0500, Len Brown wrote: > The SDM is like software -- usually (but not always) you are better > off with the latest version:-) If only it existed as a .tex file in a git repo. It has been very useful to have older versions around a number of times.

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-28 Thread Len Brown
On Tue, Feb 26, 2019 at 8:54 AM Peter Zijlstra wrote: > > > It would've been nice to have the CPUID instruction 1F leaf reference > > > 3B-3.9 in the SDM, and maybe mention this here too. > > > > I didn't mention SDM sections because they change -- leaving stale > > pointers in our commit message

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-26 Thread Peter Zijlstra
On Wed, Feb 20, 2019 at 10:08:48AM -0500, Len Brown wrote: > Thanks for the comments, Peter. I'll update the patch to address the > syntax points. (Maybe checkpatch.pl should be updated to reflect your > preferences?). Don't know about checkpatch; I ignore plenty of its output. I think tglx start

RE: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-25 Thread Brown, Len
- From: Brice Goglin [mailto:brice.gog...@inria.fr] Sent: Sunday, February 24, 2019 5:04 AM To: Len Brown ; x...@kernel.org Cc: linux-kernel@vger.kernel.org; Brown, Len ; linux-...@vger.kernel.org; Like Xu Subject: Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support Le 19/02

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-24 Thread Like Xu
On 2019/2/24 18:04, Brice Goglin wrote: Le 19/02/2019 à 04:40, Len Brown a écrit : diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index ccd1f2a8e557..4250a87f57db 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -393,6 +393,7 @@ static bool match_smt(

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-24 Thread Brice Goglin
Le 19/02/2019 à 04:40, Len Brown a écrit : > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index ccd1f2a8e557..4250a87f57db 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -393,6 +393,7 @@ static bool match_smt(struct cpuinfo_x86 *c, struct >

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-20 Thread Len Brown
Thanks for the comments, Peter. I'll update the patch to address the syntax points. (Maybe checkpatch.pl should be updated to reflect your preferences?). About macros vs C. I agree with your preference. I used macros to be consistent with the existing code, and to be as backport friendly as poss

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-20 Thread Peter Zijlstra
On Mon, Feb 18, 2019 at 10:40:05PM -0500, Len Brown wrote: > From: Len Brown > > Some new systems have multiple software-visible die within each package. > The new CPUID.1F leaf can enumerate this multi-die/package topology. > > CPUID.1F a super-set of the CPUID.B "Extended Toplogy Leaf", > and

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-19 Thread Len Brown
On Tue, Feb 19, 2019 at 9:59 PM Like Xu wrote: > > -/* leaf 0xb sub-leaf types */ > > +/* extended topology sub-leaf types */ > > #define INVALID_TYPE0 > > #define SMT_TYPE1 > > #define CORE_TYPE 2 > > +#define DIE_TYPE 5 > > This patch set is going to export die topology

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-19 Thread Like Xu
On 2019/2/19 11:40, Len Brown wrote: From: Len Brown Some new systems have multiple software-visible die within each package. The new CPUID.1F leaf can enumerate this multi-die/package topology. CPUID.1F a super-set of the CPUID.B "Extended Toplogy Leaf", and a common updated routine can parse

RE: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-19 Thread Brown, Len
>> @@ -461,7 +463,7 @@ static bool match_llc(struct cpuinfo_x86 *c, struct >> cpuinfo_x86 *o) >>*/ >> static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o) >> { >> -if (c->>phys_proc_id == o->>phys_proc_id) >> +if (c->>cpu_die_id == o->>cpu_die_id) >> ret

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-19 Thread Liang, Kan
On 2/18/2019 10:40 PM, Len Brown wrote: From: Len Brown Some new systems have multiple software-visible die within each package. The new CPUID.1F leaf can enumerate this multi-die/package topology. CPUID.1F a super-set of the CPUID.B "Extended Toplogy Leaf", and a common updated routine can

[PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-18 Thread Len Brown
From: Len Brown Some new systems have multiple software-visible die within each package. The new CPUID.1F leaf can enumerate this multi-die/package topology. CPUID.1F a super-set of the CPUID.B "Extended Toplogy Leaf", and a common updated routine can parse either leaf. Legacy systems without C