Re: [PATCH 03/12] __wr_after_init: generic header

2018-12-22 Thread Igor Stoppa
On 21/12/2018 21:45, Matthew Wilcox wrote: On Fri, Dec 21, 2018 at 11:38:16AM -0800, Nadav Amit wrote: On Dec 19, 2018, at 1:33 PM, Igor Stoppa wrote: +static inline void *wr_memset(void *p, int c, __kernel_size_t len) +{ + return __wr_op((unsigned long)p, (unsigned long)c, len,

Re: [PATCH 03/12] __wr_after_init: generic header

2018-12-21 Thread Matthew Wilcox
On Fri, Dec 21, 2018 at 11:38:16AM -0800, Nadav Amit wrote: > > On Dec 19, 2018, at 1:33 PM, Igor Stoppa wrote: > > > > +static inline void *wr_memset(void *p, int c, __kernel_size_t len) > > +{ > > + return __wr_op((unsigned long)p, (unsigned long)c, len, WR_MEMSET); > > +} > > What do you

Re: [PATCH 03/12] __wr_after_init: generic header

2018-12-21 Thread Nadav Amit
> On Dec 19, 2018, at 1:33 PM, Igor Stoppa wrote: > > +static inline void *wr_memset(void *p, int c, __kernel_size_t len) > +{ > + return __wr_op((unsigned long)p, (unsigned long)c, len, WR_MEMSET); > +} What do you think about doing something like: #define __wr

[PATCH 03/12] __wr_after_init: generic header

2018-12-19 Thread Igor Stoppa
The header provides: - the generic part of the write rare functionality for static data - the dummy functionality, in case an arch doesn't support write rare or the functionality is disabled The basic functions are: - wr_memset(): write rare counterpart of memset() - wr_memcpy(): write rare