On Tue, 16 Apr 2019 20:38:32 +0200 Christian König wrote:
> @@ -688,9 +689,9 @@ struct sg_table *dma_buf_map_attachment(struct 
> dma_buf_attachment *attach,
>       if (attach->sgt)
>               return attach->sgt;
>  
> -     sg_table = attach->dmabuf->ops->map_dma_buf(attach, direction);
> -     if (!sg_table)
> -             sg_table = ERR_PTR(-ENOMEM);
> +     reservation_object_lock(attach->dmabuf->resv, NULL);
> +     sg_table = dma_buf_map_attachment_locked(attach, direction);
> +     reservation_object_unlock(attach->dmabuf->resv);
>  
Looks better if sg_table is checked after mapping, and feed error info
back in case there is anything unusual.

>       return sg_table;
>  }

Best Regards
Hillf

_______________________________________________
amd-gfx mailing list
amd-...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to