Re: [PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count

2018-02-27 Thread Andy Gross
On Sat, Feb 03, 2018 at 01:28:08PM +0530, Abhishek Sahu wrote: > The rx_nents and tx_nents are redundant. rx_buf and tx_buf can > be used for total number of SG entries. > > Signed-off-by: Abhishek Sahu > --- Naming conventions aside, Reviewed-by: Andy Gross

Re: [PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count

2018-02-27 Thread Christ, Austin
I agree with Sricharan's comments about naming, otherwise looks good. Tested on Centriq 2400 Reviewed-by: Austin Christ On 2/3/2018 12:58 AM, Abhishek Sahu wrote: The rx_nents and tx_nents are redundant. rx_buf and tx_buf can be used for total number of SG entries. Signed-off-by: Abhishek Sa

Re: [PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count

2018-02-19 Thread Abhishek Sahu
On 2018-02-09 07:46, Sricharan R wrote: Hi Abhishek, On 2/3/2018 1:28 PM, Abhishek Sahu wrote: The rx_nents and tx_nents are redundant. rx_buf and tx_buf can be used for total number of SG entries. Signed-off-by: Abhishek Sahu --- drivers/i2c/busses/i2c-qup.c | 26 ++

Re: [PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count

2018-02-08 Thread Sricharan R
Hi Abhishek, On 2/3/2018 1:28 PM, Abhishek Sahu wrote: > The rx_nents and tx_nents are redundant. rx_buf and tx_buf can > be used for total number of SG entries. > > Signed-off-by: Abhishek Sahu > --- > drivers/i2c/busses/i2c-qup.c | 26 ++ > 1 file changed, 10 insertion

[PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count

2018-02-03 Thread Abhishek Sahu
The rx_nents and tx_nents are redundant. rx_buf and tx_buf can be used for total number of SG entries. Signed-off-by: Abhishek Sahu --- drivers/i2c/busses/i2c-qup.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/dri