Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h_load

2019-07-29 Thread Rik van Riel
On Mon, 2019-07-29 at 22:05 +0200, Peter Zijlstra wrote: > On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote: > > @@ -3012,25 +2983,24 @@ static inline int > > throttled_hierarchy(struct cfs_rq *cfs_rq); > > static void update_cfs_group(struct sched_entity *se) > > { > > struct cfs

Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h_load

2019-07-29 Thread Peter Zijlstra
On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote: > @@ -263,8 +258,8 @@ ___update_load_avg(struct sched_avg *sa, unsigned long > load, unsigned long runna > > int __update_load_avg_blocked_se(u64 now, struct sched_entity *se) > { > - if (___update_load_sum(now, &se->avg, 0, 0,

Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h_load

2019-07-29 Thread Peter Zijlstra
On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote: > The runnable_load magic is used to quickly propagate information about > runnable tasks up the hierarchy of runqueues. The runnable_load_avg is > mostly used for the load balancing code, which only examines the value at > the root cfs_

Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h_load

2019-07-29 Thread Peter Zijlstra
On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote: > @@ -3012,25 +2983,24 @@ static inline int throttled_hierarchy(struct cfs_rq > *cfs_rq); > static void update_cfs_group(struct sched_entity *se) > { > struct cfs_rq *gcfs_rq = group_cfs_rq(se); > - long shares, runnable; >

[PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h_load

2019-07-22 Thread Rik van Riel
The runnable_load magic is used to quickly propagate information about runnable tasks up the hierarchy of runqueues. The runnable_load_avg is mostly used for the load balancing code, which only examines the value at the root cfs_rq. Redefine the root cfs_rq runnable_load_avg to be the sum of task_