Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3

2016-06-24 Thread Ondřej Jirman
On 25.6.2016 02:54, Chen-Yu Tsai wrote: > On Sat, Jun 25, 2016 at 8:35 AM, Ondřej Jirman wrote: >> On 24.6.2016 05:09, Chen-Yu Tsai wrote: +static int sun8i_ths_h3_init(struct platform_device *pdev, +struct sun8i_ths_data *data) +{ + int ret; >

Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3

2016-06-24 Thread Chen-Yu Tsai
On Sat, Jun 25, 2016 at 8:35 AM, Ondřej Jirman wrote: > On 24.6.2016 05:09, Chen-Yu Tsai wrote: >>> +static int sun8i_ths_h3_init(struct platform_device *pdev, >>> +struct sun8i_ths_data *data) >>> +{ >>> + int ret; >>> + size_t callen; >>> + s32 *cald

Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3

2016-06-24 Thread Ondřej Jirman
On 24.6.2016 05:09, Chen-Yu Tsai wrote: >> +static int sun8i_ths_h3_init(struct platform_device *pdev, >> +struct sun8i_ths_data *data) >> +{ >> + int ret; >> + size_t callen; >> + s32 *caldata; >> + >> + data->busclk = devm_clk_get(&pdev->dev, "a

Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3

2016-06-24 Thread Ondřej Jirman
Thanks, I've incorporated all the suggestions (and more :)), except for the threaded IRQ, which si expalined below. regards, Ondrej On 24.6.2016 05:09, Chen-Yu Tsai wrote: > Hi, > > On Fri, Jun 24, 2016 at 3:20 AM, wrote: >> From: Ondrej Jirman >> > > The subject could read: > > thermal

Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3

2016-06-23 Thread Chen-Yu Tsai
Hi, On Fri, Jun 24, 2016 at 3:20 AM, wrote: > From: Ondrej Jirman > The subject could read: thermal: sun8i_ths: Add support for the thermal sensor on Allwinner H3 > This patch adds support for the sun8i thermal sensor on > Allwinner H3 SoC. > > Signed-off-by: Ondřej Jirman > --- > driver

[PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3

2016-06-23 Thread megous
From: Ondrej Jirman This patch adds support for the sun8i thermal sensor on Allwinner H3 SoC. Signed-off-by: Ondřej Jirman --- drivers/thermal/Kconfig | 7 ++ drivers/thermal/Makefile| 1 + drivers/thermal/sun8i_ths.c | 295 3 files chan