Re: [PATCH 03/15] x86/kprobes: Fix frame pointer annotations

2019-06-11 Thread Peter Zijlstra
On Fri, Jun 07, 2019 at 09:36:02AM -0400, Josh Poimboeuf wrote: > On Fri, Jun 07, 2019 at 10:02:10PM +0900, Masami Hiramatsu wrote: > > On Wed, 05 Jun 2019 15:07:56 +0200 > > Peter Zijlstra wrote: > > > > > The kprobe trampolines have a FRAME_POINTER annotation that makes no > > > sense. It marks

Re: [PATCH 03/15] x86/kprobes: Fix frame pointer annotations

2019-06-07 Thread Masami Hiramatsu
On Fri, 7 Jun 2019 09:36:02 -0400 Josh Poimboeuf wrote: > On Fri, Jun 07, 2019 at 10:02:10PM +0900, Masami Hiramatsu wrote: > > On Wed, 05 Jun 2019 15:07:56 +0200 > > Peter Zijlstra wrote: > > > > > The kprobe trampolines have a FRAME_POINTER annotation that makes no > > > sense. It marks the f

Re: [PATCH 03/15] x86/kprobes: Fix frame pointer annotations

2019-06-07 Thread Josh Poimboeuf
On Fri, Jun 07, 2019 at 10:02:10PM +0900, Masami Hiramatsu wrote: > On Wed, 05 Jun 2019 15:07:56 +0200 > Peter Zijlstra wrote: > > > The kprobe trampolines have a FRAME_POINTER annotation that makes no > > sense. It marks the frame in the middle of pt_regs, at the place of > > saving BP. > > com

Re: [PATCH 03/15] x86/kprobes: Fix frame pointer annotations

2019-06-07 Thread Masami Hiramatsu
On Wed, 05 Jun 2019 15:07:56 +0200 Peter Zijlstra wrote: > The kprobe trampolines have a FRAME_POINTER annotation that makes no > sense. It marks the frame in the middle of pt_regs, at the place of > saving BP. commit ee213fc72fd67 introduced this code, and this is for unwinder which uses frame

[PATCH 03/15] x86/kprobes: Fix frame pointer annotations

2019-06-05 Thread Peter Zijlstra
The kprobe trampolines have a FRAME_POINTER annotation that makes no sense. It marks the frame in the middle of pt_regs, at the place of saving BP. Change it to mark the pt_regs frame as per the ENCODE_FRAME_POINTER from the respective entry_*.S. Signed-off-by: Peter Zijlstra (Intel) --- arch/x