Re: [PATCH 03/15 V3] perf c2c: Shared data analyser

2014-04-08 Thread Andi Kleen
Namhyung Kim writes: > > Well, I'm not sure ;-) Yes, the c2c is a complex tool which might > deserve an own command, but the functionality is very similar and I > guess there's something to share between them. They work very differently. I don't see a lot of potential for sharing. perf mem is

Re: [PATCH 03/15 V3] perf c2c: Shared data analyser

2014-04-08 Thread Namhyung Kim
On Tue, 8 Apr 2014 10:22:26 -0400, Don Zickus wrote: > On Tue, Apr 08, 2014 at 03:59:15PM +0900, Namhyung Kim wrote: >> Hi Don, >> >> On Mon, 24 Mar 2014 15:36:54 -0400, Don Zickus wrote: >> > From: Arnaldo Carvalho de Melo >> > >> > This is the start of a new perf tool that will collect informat

Re: [PATCH 03/15 V3] perf c2c: Shared data analyser

2014-04-08 Thread Don Zickus
On Tue, Apr 08, 2014 at 03:59:15PM +0900, Namhyung Kim wrote: > Hi Don, > > On Mon, 24 Mar 2014 15:36:54 -0400, Don Zickus wrote: > > From: Arnaldo Carvalho de Melo > > > > This is the start of a new perf tool that will collect information about > > memory accesses and analyse it to find things l

Re: [PATCH 03/15 V3] perf c2c: Shared data analyser

2014-04-08 Thread Don Zickus
On Tue, Apr 08, 2014 at 03:59:15PM +0900, Namhyung Kim wrote: > Hi Don, Oh by the way, thank you for your review. I will clean up a bunch of stuff based on your suggestions. Cheers, Don > > On Mon, 24 Mar 2014 15:36:54 -0400, Don Zickus wrote: > > From: Arnaldo Carvalho de Melo > > > > This i

Re: [PATCH 03/15 V3] perf c2c: Shared data analyser

2014-04-08 Thread Namhyung Kim
Hi Don, On Mon, 24 Mar 2014 15:36:54 -0400, Don Zickus wrote: > From: Arnaldo Carvalho de Melo > > This is the start of a new perf tool that will collect information about > memory accesses and analyse it to find things like hot cachelines, etc. So why not integrating this into existing 'perf me

[PATCH 03/15 V3] perf c2c: Shared data analyser

2014-03-24 Thread Don Zickus
From: Arnaldo Carvalho de Melo This is the start of a new perf tool that will collect information about memory accesses and analyse it to find things like hot cachelines, etc. This is basically trying to get a prototype written by Richard Fowles written using the tools/perf coding style and libr