Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-25 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, May 22, 2020 at 10:17 PM Wolfram Sang wrote: > > > According to the Hardware User's Manual Rev. 1.00, the registers do exist > > > on all RZ/G1, except for RZ/G1E (see below). > > > > > >"(automatic transmission can be used as a hardware function, but this > > > is > > >

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-22 Thread Wolfram Sang
> > According to the Hardware User's Manual Rev. 1.00, the registers do exist > > on all RZ/G1, except for RZ/G1E (see below). > > > >"(automatic transmission can be used as a hardware function, but this is > > not meaningful for actual use cases)." > > > > (whatever that comment may mean?

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-22 Thread Lad, Prabhakar
Hi Wolfram, On Mon, May 18, 2020 at 11:10 AM Geert Uytterhoeven wrote: > > Hi Wolfram, > > On Mon, May 18, 2020 at 11:26 AM Wolfram Sang > wrote: > > > > However, both versions (with and without automatic transmission) are > > > > described with the same "renesas,iic-r8a7742" compatible. Is it p

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, May 18, 2020 at 11:26 AM Wolfram Sang wrote: > > > However, both versions (with and without automatic transmission) are > > > described with the same "renesas,iic-r8a7742" compatible. Is it possible > > > to detect the reduced variant at runtime somehow? > > > > > I couldn't f

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Wolfram Sang
Hi Prabhakar, > > Leaves us with a seperate compatible entry for it? > > > Sounds okay to me, how about "renesas,iic-no-dvfs" ? So that this > could be used on all the SoC's which don't support DVFS. Well, the feature missing is used for DVFS, but its name is "automatic transmission". So, I'd rat

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Lad, Prabhakar
Hi Wolfram, On Mon, May 18, 2020 at 10:26 AM Wolfram Sang wrote: > > > > > However, both versions (with and without automatic transmission) are > > > described with the same "renesas,iic-r8a7742" compatible. Is it possible > > > to detect the reduced variant at runtime somehow? > > > > > I couldn

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Wolfram Sang
> > However, both versions (with and without automatic transmission) are > > described with the same "renesas,iic-r8a7742" compatible. Is it possible > > to detect the reduced variant at runtime somehow? > > > I couldn't find anything the manual that would be useful to detect at runtime. > > > My

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Lad, Prabhakar
Hi Wolfram, Thank for the review. On Fri, May 15, 2020 at 6:10 PM Wolfram Sang wrote: > > On Fri, May 15, 2020 at 04:08:43PM +0100, Lad Prabhakar wrote: > > Add the I2C[0-3] and IIC[0-3] devices nodes to the R8A7742 device tree. > > > > Automatic transmission for PMIC control is not available on

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-15 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:43PM +0100, Lad Prabhakar wrote: > Add the I2C[0-3] and IIC[0-3] devices nodes to the R8A7742 device tree. > > Automatic transmission for PMIC control is not available on IIC3 hence > compatible string "renesas,rcar-gen2-iic" and "renesas,rmobile-iic" is > not added t

[PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-15 Thread Lad Prabhakar
Add the I2C[0-3] and IIC[0-3] devices nodes to the R8A7742 device tree. Automatic transmission for PMIC control is not available on IIC3 hence compatible string "renesas,rcar-gen2-iic" and "renesas,rmobile-iic" is not added to iic3 node. Signed-off-by: Lad Prabhakar Reviewed-by: Marian-Cristian