Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-12 Thread Samuel Iglesias Gonsálvez
On Wed, 2012-09-12 at 14:28 +0200, Jens Taprogge wrote: [...] > Sam, > > can you please add the endianess-aware versions back? Patch attached. > > One of the earlier uses was not correct. Done! The patch will be submitted with the next batch. Thanks, Sam signature.asc Description: This i

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-12 Thread Jens Taprogge
On Wed, Sep 12, 2012 at 02:59:26PM +0300, Dan Carpenter wrote: > On Wed, Sep 12, 2012 at 01:21:17PM +0200, Samuel Iglesias Gonsálvez wrote: > > On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote: > > > On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote: > > > > On Tue, Sep 11, 2012 a

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-12 Thread Dan Carpenter
On Wed, Sep 12, 2012 at 01:21:17PM +0200, Samuel Iglesias Gonsálvez wrote: > On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote: > > On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote: > > > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote: > > > > > +static int tpci200_

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-12 Thread Jens Taprogge
On Wed, Sep 12, 2012 at 02:13:30PM +0300, Dan Carpenter wrote: > On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote: > > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote: > > > > +static int tpci200_get_clockrate(struct ipack_device *dev) > > > > +{ > > > > + struct tp

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-12 Thread Samuel Iglesias Gonsálvez
On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote: > On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote: > > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote: > > > > +static int tpci200_get_clockrate(struct ipack_device *dev) > > > > +{ > > > > + struct tpci200_b

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-12 Thread Dan Carpenter
On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote: > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote: > > > +static int tpci200_get_clockrate(struct ipack_device *dev) > > > +{ > > > + struct tpci200_board *tpci200 = check_slot(dev); > > > + __le16 __iomem *addr; > > > >

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-12 Thread Jens Taprogge
On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote: > > I had a few style comments on this patchset. Nothing that couldn't > be fixed later. > > On Mon, Sep 10, 2012 at 10:51:41AM +0200, Samuel Iglesias Gonsálvez wrote: > > From: Jens Taprogge > > > > Provide get_clockrate, set_cloc

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-11 Thread Dan Carpenter
I had a few style comments on this patchset. Nothing that couldn't be fixed later. On Mon, Sep 10, 2012 at 10:51:41AM +0200, Samuel Iglesias Gonsálvez wrote: > From: Jens Taprogge > > Provide get_clockrate, set_clockrate, get_error, get_timeout and reset_timeout > callbacks. > > Signed-off-by

[PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

2012-09-10 Thread Samuel Iglesias Gonsálvez
From: Jens Taprogge Provide get_clockrate, set_clockrate, get_error, get_timeout and reset_timeout callbacks. Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c | 107 +++ 1 file changed, 107 insertion