Re: [PATCH 03/22] x86/kvm: Fix frame pointer usage in vmx_vmenter()

2019-07-15 Thread Paolo Bonzini
On 15/07/19 15:35, Josh Poimboeuf wrote: > On Mon, Jul 15, 2019 at 03:03:23PM +0200, Paolo Bonzini wrote: >> On 15/07/19 14:37, Josh Poimboeuf wrote: >>> Would it make sense to remove the call to vmx_vmenter() altogether, and >>> just either embed it in __vmx_vcpu_run(), or jmp back and forth to

Re: [PATCH 03/22] x86/kvm: Fix frame pointer usage in vmx_vmenter()

2019-07-15 Thread Josh Poimboeuf
On Mon, Jul 15, 2019 at 03:03:23PM +0200, Paolo Bonzini wrote: > On 15/07/19 14:37, Josh Poimboeuf wrote: > > On Mon, Jul 15, 2019 at 11:04:03AM +0200, Paolo Bonzini wrote: > >> On 15/07/19 02:36, Josh Poimboeuf wrote: > >>> With CONFIG_FRAME_POINTER, vmx_vmenter() needs to do frame pointer setup

Re: [PATCH 03/22] x86/kvm: Fix frame pointer usage in vmx_vmenter()

2019-07-15 Thread Paolo Bonzini
On 15/07/19 14:37, Josh Poimboeuf wrote: > On Mon, Jul 15, 2019 at 11:04:03AM +0200, Paolo Bonzini wrote: >> On 15/07/19 02:36, Josh Poimboeuf wrote: >>> With CONFIG_FRAME_POINTER, vmx_vmenter() needs to do frame pointer setup >>> before calling kvm_spurious_fault(). >>> >>> Fixes the following

Re: [PATCH 03/22] x86/kvm: Fix frame pointer usage in vmx_vmenter()

2019-07-15 Thread Josh Poimboeuf
On Mon, Jul 15, 2019 at 11:04:03AM +0200, Paolo Bonzini wrote: > On 15/07/19 02:36, Josh Poimboeuf wrote: > > With CONFIG_FRAME_POINTER, vmx_vmenter() needs to do frame pointer setup > > before calling kvm_spurious_fault(). > > > > Fixes the following warning: > > > >

Re: [PATCH 03/22] x86/kvm: Fix frame pointer usage in vmx_vmenter()

2019-07-15 Thread Paolo Bonzini
On 15/07/19 02:36, Josh Poimboeuf wrote: > With CONFIG_FRAME_POINTER, vmx_vmenter() needs to do frame pointer setup > before calling kvm_spurious_fault(). > > Fixes the following warning: > > arch/x86/kvm/vmx/vmenter.o: warning: objtool: vmx_vmenter()+0x14: call > without frame pointer

[PATCH 03/22] x86/kvm: Fix frame pointer usage in vmx_vmenter()

2019-07-14 Thread Josh Poimboeuf
With CONFIG_FRAME_POINTER, vmx_vmenter() needs to do frame pointer setup before calling kvm_spurious_fault(). Fixes the following warning: arch/x86/kvm/vmx/vmenter.o: warning: objtool: vmx_vmenter()+0x14: call without frame pointer save/setup Signed-off-by: Josh Poimboeuf --- Cc: Paolo