Re: [PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq

2015-04-30 Thread Johan Hovold
On Wed, Apr 29, 2015 at 11:48:57PM +0200, Linus Walleij wrote: > On Tue, Apr 21, 2015 at 5:42 PM, Johan Hovold wrote: > > > Drop redundant lock-as-irq in gpio_setup_irq, which has already been > > handled when requesting and releasing the irq (i.e. in the irq chip > > irq_request_resources and

Re: [PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq

2015-04-30 Thread Johan Hovold
On Wed, Apr 29, 2015 at 11:48:57PM +0200, Linus Walleij wrote: On Tue, Apr 21, 2015 at 5:42 PM, Johan Hovold jo...@kernel.org wrote: Drop redundant lock-as-irq in gpio_setup_irq, which has already been handled when requesting and releasing the irq (i.e. in the irq chip

Re: [PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq

2015-04-29 Thread Linus Walleij
On Tue, Apr 21, 2015 at 5:42 PM, Johan Hovold wrote: > Drop redundant lock-as-irq in gpio_setup_irq, which has already been > handled when requesting and releasing the irq (i.e. in the irq chip > irq_request_resources and irq_release_resources callbacks). Well we would hope they all do that.

Re: [PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq

2015-04-29 Thread Linus Walleij
On Tue, Apr 21, 2015 at 5:42 PM, Johan Hovold jo...@kernel.org wrote: Drop redundant lock-as-irq in gpio_setup_irq, which has already been handled when requesting and releasing the irq (i.e. in the irq chip irq_request_resources and irq_release_resources callbacks). Well we would hope they

[PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq

2015-04-21 Thread Johan Hovold
Drop redundant lock-as-irq in gpio_setup_irq, which has already been handled when requesting and releasing the irq (i.e. in the irq chip irq_request_resources and irq_release_resources callbacks). Note that we would be leaking the irq in the gpiochip_lock_as_irq error path if the (second)

[PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq

2015-04-21 Thread Johan Hovold
Drop redundant lock-as-irq in gpio_setup_irq, which has already been handled when requesting and releasing the irq (i.e. in the irq chip irq_request_resources and irq_release_resources callbacks). Note that we would be leaking the irq in the gpiochip_lock_as_irq error path if the (second)