Re: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210

2020-09-07 Thread Krzysztof Kozlowski
On Mon, Sep 07, 2020 at 02:49:49PM -0700, Jonathan Bakker wrote: > Looking at this again, it appears that there is actually control for > it at offset 0x6818 of pmu_syscon (0xe0108000) [1]. However, it defaults to > enabled so it's not required for proper use of the block. Whether it should > be

Re: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210

2020-09-07 Thread Jonathan Bakker
Looking at this again, it appears that there is actually control for it at offset 0x6818 of pmu_syscon (0xe0108000) [1]. However, it defaults to enabled so it's not required for proper use of the block. Whether it should be present in the schema/DTS is up to you. Thanks, Jonathan [1] https://a

Re: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210

2020-09-07 Thread Jonathan Cameron
On Mon, 7 Sep 2020 18:11:19 +0200 Krzysztof Kozlowski wrote: > The ADC in S5Pv210 does not have ADC phy registers in separate block for > which syscon would be needed. Remove this requirement to fix dtbs_check > warnings like: > > arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e170:

[PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210

2020-09-07 Thread Krzysztof Kozlowski
The ADC in S5Pv210 does not have ADC phy registers in separate block for which syscon would be needed. Remove this requirement to fix dtbs_check warnings like: arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e170: 'samsung,syscon-phandle' is a required property Signed-off-by: Krzysztof