Re: [PATCH 03/33] task containersv11 add tasks file interface

2007-10-03 Thread Paul Jackson
One more cgroup code review detail ... The following is evidence of some more stale comments in kernel/cpuset.c. Some routines which used to be in that file, but which are now reimplemented in cgroups, are still named in cpuset.c comments: $ grep -E 'cpuset_rmdir|cpuset_exit|cpuset_fork' kernel/

Re: [PATCH 03/33] task containersv11 add tasks file interface

2007-10-03 Thread Paul Menage
On 10/3/07, Paul Jackson <[EMAIL PROTECTED]> wrote: > > I can't say for sure, but I suspect that if cgroups had always > been cgroups (short for control groups), then these local 'cont' > variables would have a different name. Oh, absolutely. I just refrained from changing them in the rename since

Re: [PATCH 03/33] task containersv11 add tasks file interface

2007-10-03 Thread Paul Jackson
> > - There are many instances of the local variable 'cont', referring > >to a struct cgroup pointer. I presume the spelling 'cont' is a > >holdover from the time when we called these containers. > > Yes, and since cgroup is short for "control group", "cont" still > seemed like a reasona

Re: [PATCH 03/33] task containersv11 add tasks file interface

2007-10-03 Thread Paul Menage
On 10/3/07, Paul Jackson <[EMAIL PROTECTED]> wrote: > > So after changing the 'cpus' of a cpuset, you (something in > user space) then has to rewrite every pid in that cpusets > tasks file back to that same tasks file, in order to get the > change to be applied to each of those tasks, and get them

Re: [PATCH 03/33] task containersv11 add tasks file interface

2007-10-03 Thread Paul Jackson
Paul M wrote: > Are there cases when userspace is > required to try to reattach a task to its current cpuset in order to > get a cpu mask change to stick? Yes, there are such cases. If tasks are running in a cpuset, and someone changes the 'cpus' of that cpuset, the tasks already in that cpuset d

Re: [PATCH 03/33] task containersv11 add tasks file interface

2007-10-03 Thread Paul Menage
On 10/3/07, Paul Jackson <[EMAIL PROTECTED]> wrote: > > - What are these apparent 'exec notifications' that are provided to >user space that the following mentions - I cannot find any other >mention of them: > > With the ability to classify tasks differently for different >

Re: [PATCH 03/33] task containersv11 add tasks file interface

2007-10-03 Thread Paul Jackson
Cgroup (aka container) code review: Except for the very last item below, my other comments are minor. And the last item is pretty easy too - just more important. Overall - nice stuff. I like this generalization of the cpuset hierarchy. Thanks. === Review comments on Documentation/cgro

[PATCH 03/33] task containersv11 add tasks file interface

2007-09-17 Thread Paul Menage
Add the per-directory "tasks" file for cgroupfs mounts; this allows the user to determine which tasks are members of a cgroup by reading a cgroup's "tasks", and to move a task into a cgroup by writing its pid to its "tasks". Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/cgroup