Re: [PATCH 04/04] Add LRW

2005-01-31 Thread James Morris
On Sun, 30 Jan 2005, Matt Mackall wrote: > > > LRW and the GF(2**128) code is not configurable? > > > > No, it's a cipher mode. None of the modes is configurable. > > Is LRW an appropriate mode for anything but block storage? Looks like it is only specified for this case. "The scope of this do

Re: [PATCH 04/04] Add LRW

2005-01-30 Thread Matt Mackall
On Sun, Jan 30, 2005 at 12:49:29PM +0100, Fruhwirth Clemens wrote: > > In fact, it's lowerCamelCase, that's intentional. The problem with mixing of naming styles is that it becomes difficult to remember what style is used where. Is it foo_bar_baz() or foobarbaz() or fooBarBaz() or FooBarBaz()?

Re: [PATCH 04/04] Add LRW

2005-01-30 Thread James Morris
On Sat, 29 Jan 2005, Matt Mackall wrote: > On Mon, Jan 24, 2005 at 12:57:50PM +0100, Fruhwirth Clemens wrote: > > This is the core of my LRW patch. Added test vectors. > > http://grouper.ieee.org/groups/1619/email/pdf00017.pdf > > Please include a URL for the standard at the top of the LRW code a

Re: [PATCH 04/04] Add LRW

2005-01-30 Thread Fruhwirth Clemens
On Sat, 2005-01-29 at 16:02 -0800, Matt Mackall wrote: > On Mon, Jan 24, 2005 at 12:57:50PM +0100, Fruhwirth Clemens wrote: > > This is the core of my LRW patch. Added test vectors. > > http://grouper.ieee.org/groups/1619/email/pdf00017.pdf > > Please include a URL for the standard at the top of t

Re: [PATCH 04/04] Add LRW

2005-01-29 Thread Matt Mackall
On Mon, Jan 24, 2005 at 12:57:50PM +0100, Fruhwirth Clemens wrote: > This is the core of my LRW patch. Added test vectors. > http://grouper.ieee.org/groups/1619/email/pdf00017.pdf Please include a URL for the standard at the top of the LRW code and next to the test vectors. I had to search around

[PATCH 04/04] Add LRW

2005-01-24 Thread Fruhwirth Clemens
This is the core of my LRW patch. Added test vectors. http://grouper.ieee.org/groups/1619/email/pdf00017.pdf Please notice, that this is not a patch for dm-crypt. I will post a nice splitted patch set for dm later that day. Signed-off-by: Fruhwirth Clemens <[EMAIL PROTECTED]> --- 3/crypto/cipher.