Re: [PATCH 04/10] drm: make drm_vblank_{get,put}() static

2016-08-03 Thread Rodrigo Vivi
Oh, nevermind... I saw the places that depends on changes on other legacy usage like drm_wait_on_vblank... (not trivial on intel_crt) and other cases... So better to just go with the static for now. Feel free to use: Reviewed-by: Rodrigo Vivi On Wed, Aug 3, 2016 at

Re: [PATCH 04/10] drm: make drm_vblank_{get,put}() static

2016-08-03 Thread Rodrigo Vivi
Oh, nevermind... I saw the places that depends on changes on other legacy usage like drm_wait_on_vblank... (not trivial on intel_crt) and other cases... So better to just go with the static for now. Feel free to use: Reviewed-by: Rodrigo Vivi On Wed, Aug 3, 2016 at 12:22 AM, Daniel Vetter

Re: [PATCH 04/10] drm: make drm_vblank_{get,put}() static

2016-08-03 Thread Rodrigo Vivi
I was going to remove the legacy get/put versions right now, but decided to check if there were any pending patch in mailing lists and found this. What about deleting the functions at all instead of having it internally? On Tue, Jun 7, 2016 at 7:07 AM, Gustavo Padovan

Re: [PATCH 04/10] drm: make drm_vblank_{get,put}() static

2016-08-03 Thread Rodrigo Vivi
I was going to remove the legacy get/put versions right now, but decided to check if there were any pending patch in mailing lists and found this. What about deleting the functions at all instead of having it internally? On Tue, Jun 7, 2016 at 7:07 AM, Gustavo Padovan wrote: > From: Gustavo

Re: [PATCH 04/10] drm: make drm_vblank_{get,put}() static

2016-08-03 Thread Daniel Vetter
On Tue, Aug 02, 2016 at 11:30:21PM -0700, Rodrigo Vivi wrote: > I was going to remove the legacy get/put versions right now, but > decided to check if there were any pending patch in mailing lists and > found this. > > What about deleting the functions at all instead of having it internally?

Re: [PATCH 04/10] drm: make drm_vblank_{get,put}() static

2016-08-03 Thread Daniel Vetter
On Tue, Aug 02, 2016 at 11:30:21PM -0700, Rodrigo Vivi wrote: > I was going to remove the legacy get/put versions right now, but > decided to check if there were any pending patch in mailing lists and > found this. > > What about deleting the functions at all instead of having it internally?

[PATCH 04/10] drm: make drm_vblank_{get,put}() static

2016-06-07 Thread Gustavo Padovan
From: Gustavo Padovan As they are not used anywhere outside drm_irq.c make them static. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/drm_irq.c | 10 ++ include/drm/drmP.h| 2 -- 2 files changed, 2

[PATCH 04/10] drm: make drm_vblank_{get,put}() static

2016-06-07 Thread Gustavo Padovan
From: Gustavo Padovan As they are not used anywhere outside drm_irq.c make them static. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/drm_irq.c | 10 ++ include/drm/drmP.h| 2 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c