Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2014-01-07 Thread Chen-Yu Tsai
Hi, On Thu, Jan 2, 2014 at 9:11 PM, srinivas kandagatla wrote: > Hi Chen, > > On 24/12/13 03:27, Chen-Yu Tsai wrote: >> Srinivas, >> >> Let's keep platform data as of_data, so SoC compatibles can pass >> hardware feature flags for cores that don't support auto-detection. > > I understand your con

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2014-01-02 Thread srinivas kandagatla
Hi Chen, On 24/12/13 03:27, Chen-Yu Tsai wrote: > Srinivas, > > Let's keep platform data as of_data, so SoC compatibles can pass > hardware feature flags for cores that don't support auto-detection. I understand your concern here, But making platform_data as of_data would just open a wide door f

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-23 Thread Chen-Yu Tsai
Hi, On Fri, Dec 13, 2013 at 6:38 PM, Maxime Ripard wrote: > On Thu, Dec 12, 2013 at 06:31:43PM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Thu, Dec 12, 2013 at 5:04 PM, Maxime Ripard >> wrote: >> > Hi, >> > >> > On Wed, Dec 11, 2013 at 02:45:08PM +, srinivas kandagatla wrote: >> >> >>> 1. .tx

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-13 Thread Maxime Ripard
On Thu, Dec 12, 2013 at 06:31:43PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Thu, Dec 12, 2013 at 5:04 PM, Maxime Ripard > wrote: > > Hi, > > > > On Wed, Dec 11, 2013 at 02:45:08PM +, srinivas kandagatla wrote: > >> >>> 1. .tx_coe > >> >>>This is not exported in the DT bindings. > >> >>>

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-12 Thread Chen-Yu Tsai
Hi, On Thu, Dec 12, 2013 at 5:04 PM, Maxime Ripard wrote: > Hi, > > On Wed, Dec 11, 2013 at 02:45:08PM +, srinivas kandagatla wrote: >> >>> 1. .tx_coe >> >>>This is not exported in the DT bindings. >> >>>Looking at stmmac code, not setting this seems to disable all >> >>>checksum

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-12 Thread Maxime Ripard
Hi, On Wed, Dec 11, 2013 at 02:45:08PM +, srinivas kandagatla wrote: > >>> 1. .tx_coe > >>>This is not exported in the DT bindings. > >>>Looking at stmmac code, not setting this seems to disable all > >>>checksum offloading. > >> > >> Why cant this go via DT as well? > > > > If yo

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-11 Thread Chen-Yu Tsai
Hi, On Wed, Dec 11, 2013 at 10:45 PM, srinivas kandagatla wrote: > Hi Chen, > > On 11/12/13 12:17, Chen-Yu Tsai wrote: > >>> >>> I would be good to get actual picture of this hw setup, On ST the >>> additional glue logic which sits on top of the GMAC is to resposible for >>> selecting the correct

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-11 Thread srinivas kandagatla
Hi Chen, On 11/12/13 12:17, Chen-Yu Tsai wrote: >> >> I would be good to get actual picture of this hw setup, On ST the >> additional glue logic which sits on top of the GMAC is to resposible for >> selecting the correct retime clock. > > I would have liked to look at the internal design, how th

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-11 Thread Chen-Yu Tsai
Hi, On Tue, Dec 10, 2013 at 10:59 PM, srinivas kandagatla wrote: > > On 09/12/13 17:34, Chen-Yu Tsai wrote: >> Hi, >> >> On Mon, Dec 9, 2013 at 7:10 PM, srinivas kandagatla >> wrote: >>> Hi Chen, >>> Good to know that Allwinner uses gmac. >> >> To my knowledge, Allwinner has never confirmed this

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-10 Thread Maxime Ripard
On Tue, Dec 10, 2013 at 02:59:57PM +, srinivas kandagatla wrote: > > On 09/12/13 17:34, Chen-Yu Tsai wrote: > > Hi, > > > > On Mon, Dec 9, 2013 at 7:10 PM, srinivas kandagatla > > wrote: > >> Hi Chen, > >> Good to know that Allwinner uses gmac. > > > > To my knowledge, Allwinner has never c

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-10 Thread Maxime Ripard
On Mon, Dec 09, 2013 at 08:04:21PM +0100, Hans de Goede wrote: > >>Now reading this has also made me take a closer look at wens' patch > >>for this. Wens, I see that you directly modify registers in the ccm > >>that is a big no-no instead you should add a helper function to > >>sunxi-clk.c and use

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-10 Thread srinivas kandagatla
On 09/12/13 17:34, Chen-Yu Tsai wrote: > Hi, > > On Mon, Dec 9, 2013 at 7:10 PM, srinivas kandagatla > wrote: >> Hi Chen, >> Good to know that Allwinner uses gmac. > > To my knowledge, Allwinner has never confirmed this. > >> On ST SoC, we have very similar requirements, before we merge any of

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Hans de Goede
Hi, On 12/09/2013 06:56 PM, Chen-Yu Tsai wrote: Hi, On Tue, Dec 10, 2013 at 12:16 AM, Hans de Goede wrote: Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these cha

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Chen-Yu Tsai
Hi, On Tue, Dec 10, 2013 at 12:16 AM, Hans de Goede wrote: > Hi, > > > On 12/09/2013 12:10 PM, srinivas kandagatla wrote: >> >> Hi Chen, >> Good to know that Allwinner uses gmac. >> >> On ST SoC, we have very similar requirements, before we merge any of >> these changes I think we need to come up

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Chen-Yu Tsai
Hi, On Mon, Dec 9, 2013 at 7:10 PM, srinivas kandagatla wrote: > Hi Chen, > Good to know that Allwinner uses gmac. To my knowledge, Allwinner has never confirmed this. > On ST SoC, we have very similar requirements, before we merge any of > these changes I think we need to come up with common w

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Hans de Goede
Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these changes I think we need to come up with common way to solve both Allwinner and ST SOCs use cases. I have already pos

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Chen-Yu Tsai
Hi, On Mon, Dec 9, 2013 at 9:44 PM, Sergei Shtylyov wrote: > Hello. > > > On 09-12-2013 15:21, srinivas kandagatla wrote: > >>> +static int sun7i_gmac_init(struct platform_device *pdev) >>> +{ >>> + struct resource *res; >>> + struct device *dev = &pdev->dev; >>> + void __iomem

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Sergei Shtylyov
Hello. On 09-12-2013 15:21, srinivas kandagatla wrote: +static int sun7i_gmac_init(struct platform_device *pdev) +{ + struct resource *res; + struct device *dev = &pdev->dev; + void __iomem *addr = NULL; + struct plat_stmmacenet_data *plat_dat = NULL; No need to ini

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread srinivas kandagatla
On 06/12/13 17:29, Chen-Yu Tsai wrote: > +static int sun7i_gmac_init(struct platform_device *pdev) > +{ > + struct resource *res; > + struct device *dev = &pdev->dev; > + void __iomem *addr = NULL; > + struct plat_stmmacenet_data *plat_dat = NULL; > + u32 priv_clk_reg; > + > +

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread srinivas kandagatla
Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these changes I think we need to come up with common way to solve both Allwinner and ST SOCs use cases. I have already posted few patches on to net-dev http://lkml.org/lkml/2013/11

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-07 Thread Emilio López
El 07/12/13 09:50, Tomasz Figa escribió: On Saturday 07 of December 2013 12:46:16 Maxime Ripard wrote: On Sat, Dec 07, 2013 at 12:12:26PM +0100, Tomasz Figa wrote: On Saturday 07 of December 2013 11:27:10 Maxime Ripard wrote: Chen-Yu, Mike, On Sat, Dec 07, 2013 at 01:29:37AM +0800, Chen-Yu Ts

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-07 Thread Tomasz Figa
On Saturday 07 of December 2013 12:46:16 Maxime Ripard wrote: > On Sat, Dec 07, 2013 at 12:12:26PM +0100, Tomasz Figa wrote: > > On Saturday 07 of December 2013 11:27:10 Maxime Ripard wrote: > > > Chen-Yu, Mike, > > > > > > On Sat, Dec 07, 2013 at 01:29:37AM +0800, Chen-Yu Tsai wrote: > > > > The

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-07 Thread Maxime Ripard
On Sat, Dec 07, 2013 at 12:12:26PM +0100, Tomasz Figa wrote: > On Saturday 07 of December 2013 11:27:10 Maxime Ripard wrote: > > Chen-Yu, Mike, > > > > On Sat, Dec 07, 2013 at 01:29:37AM +0800, Chen-Yu Tsai wrote: > > > The Allwinner A20 has an ethernet controller that seems to be > > > an early v

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-07 Thread Tomasz Figa
On Saturday 07 of December 2013 11:27:10 Maxime Ripard wrote: > Chen-Yu, Mike, > > On Sat, Dec 07, 2013 at 01:29:37AM +0800, Chen-Yu Tsai wrote: > > The Allwinner A20 has an ethernet controller that seems to be > > an early version of Synopsys DesignWare MAC 10/100/1000 Universal, > > which is sup

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-07 Thread Maxime Ripard
Chen-Yu, Mike, On Sat, Dec 07, 2013 at 01:29:37AM +0800, Chen-Yu Tsai wrote: > The Allwinner A20 has an ethernet controller that seems to be > an early version of Synopsys DesignWare MAC 10/100/1000 Universal, > which is supported by the stmmac driver. > > Allwinner's GMAC requires setting additi

[PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-06 Thread Chen-Yu Tsai
The Allwinner A20 has an ethernet controller that seems to be an early version of Synopsys DesignWare MAC 10/100/1000 Universal, which is supported by the stmmac driver. Allwinner's GMAC requires setting additional registers in the SoC's clock control unit. The exact version of the DWMAC IP that