Re: [PATCH 04/10] perf sched timehist: Split is_idle_sample()

Hi David, On Mon, Dec 05, 2016 at 07:57:43PM -0800, David Ahern wrote: > On 12/5/16 7:40 PM, Namhyung Kim wrote: > > The is_idle_sample() function actually does more than determining > > whether sample come from idle task. Split the callchain part into > > save_task_callchain() to make it clearer

Re: [PATCH 04/10] perf sched timehist: Split is_idle_sample()

On 12/5/16 7:40 PM, Namhyung Kim wrote: > The is_idle_sample() function actually does more than determining > whether sample come from idle task. Split the callchain part into > save_task_callchain() to make it clearer. Also checking prev_pid from > trace data looks unnecessary since it should be

[PATCH 04/10] perf sched timehist: Split is_idle_sample()

The is_idle_sample() function actually does more than determining whether sample come from idle task. Split the callchain part into save_task_callchain() to make it clearer. Also checking prev_pid from trace data looks unnecessary since it should be always same as sample->pid. Signed-off-by: Nam