Re: [PATCH 04/11] HID: logitech-dj: remove hidinput_input_event

2014-02-03 Thread David Herrmann
Hi On Mon, Feb 3, 2014 at 5:21 PM, Benjamin Tissoires wrote: > On Mon, Feb 3, 2014 at 11:06 AM, David Herrmann wrote: >> Hi >> >> On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires >> wrote: >>> hid-logitech-dj uses its own ->hidinput_input_event() instead of >>> the generic binding in

Re: [PATCH 04/11] HID: logitech-dj: remove hidinput_input_event

2014-02-03 Thread Benjamin Tissoires
On Mon, Feb 3, 2014 at 11:06 AM, David Herrmann wrote: > Hi > > On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires > wrote: >> hid-logitech-dj uses its own ->hidinput_input_event() instead of >> the generic binding in hid-input. >> Moving the handling of LEDs towards

Re: [PATCH 04/11] HID: logitech-dj: remove hidinput_input_event

2014-02-03 Thread David Herrmann
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires wrote: > hid-logitech-dj uses its own ->hidinput_input_event() instead of > the generic binding in hid-input. > Moving the handling of LEDs towards logi_dj_output_hidraw_report() > allows two things: > - remove hidinput_input_event in struct

Re: [PATCH 04/11] HID: logitech-dj: remove hidinput_input_event

2014-02-03 Thread David Herrmann
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: hid-logitech-dj uses its own -hidinput_input_event() instead of the generic binding in hid-input. Moving the handling of LEDs towards logi_dj_output_hidraw_report() allows two things: - remove

Re: [PATCH 04/11] HID: logitech-dj: remove hidinput_input_event

2014-02-03 Thread Benjamin Tissoires
On Mon, Feb 3, 2014 at 11:06 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: hid-logitech-dj uses its own -hidinput_input_event() instead of the generic binding in hid-input. Moving the handling of

Re: [PATCH 04/11] HID: logitech-dj: remove hidinput_input_event

2014-02-03 Thread David Herrmann
Hi On Mon, Feb 3, 2014 at 5:21 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Mon, Feb 3, 2014 at 11:06 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: hid-logitech-dj uses its own

[PATCH 04/11] HID: logitech-dj: remove hidinput_input_event

2014-02-01 Thread Benjamin Tissoires
hid-logitech-dj uses its own ->hidinput_input_event() instead of the generic binding in hid-input. Moving the handling of LEDs towards logi_dj_output_hidraw_report() allows two things: - remove hidinput_input_event in struct hid_device - hidraw user space programs can also set the LEDs

[PATCH 04/11] HID: logitech-dj: remove hidinput_input_event

2014-02-01 Thread Benjamin Tissoires
hid-logitech-dj uses its own -hidinput_input_event() instead of the generic binding in hid-input. Moving the handling of LEDs towards logi_dj_output_hidraw_report() allows two things: - remove hidinput_input_event in struct hid_device - hidraw user space programs can also set the LEDs