Re: [PATCH 04/11] fs: Don't remove suid for CAP_FSETID for userns root

On Sat, Dec 23, 2017 at 1:38 PM, Dongsu Park wrote: > Hi, > > On Sat, Dec 23, 2017 at 4:26 AM, Serge E. Hallyn wrote: >> On Fri, Dec 22, 2017 at 03:32:28PM +0100, Dongsu Park wrote: >>> From: Seth Forshee >>> >>> Expand the check in should_remove_suid() to keep privileges for >> >> I realize thi

Re: [PATCH 04/11] fs: Don't remove suid for CAP_FSETID for userns root

Hi, On Sat, Dec 23, 2017 at 4:26 AM, Serge E. Hallyn wrote: > On Fri, Dec 22, 2017 at 03:32:28PM +0100, Dongsu Park wrote: >> From: Seth Forshee >> >> Expand the check in should_remove_suid() to keep privileges for > > I realize this description came from Seth, but reading it now, > 'Expand' see

Re: [PATCH 04/11] fs: Don't remove suid for CAP_FSETID for userns root

On Fri, Dec 22, 2017 at 03:32:28PM +0100, Dongsu Park wrote: > From: Seth Forshee > > Expand the check in should_remove_suid() to keep privileges for I realize this description came from Seth, but reading it now, 'Expand' seems wrong. Expanding a check brings to my mind making it stricter, not

[PATCH 04/11] fs: Don't remove suid for CAP_FSETID for userns root

From: Seth Forshee Expand the check in should_remove_suid() to keep privileges for CAP_FSETID in s_user_ns rather than init_user_ns. Patch v4 is available: https://patchwork.kernel.org/patch/8944621/ --EWB Changed from ns_capable(sb->s_user_ns, ) to capable_wrt_inode_uidgid Cc: linux-fsde...@v