Re: [PATCH 04/11] kernfs: don't set dentry->d_fsdata

2017-06-12 Thread Tejun Heo
Hello, On Fri, Jun 02, 2017 at 02:53:57PM -0700, Shaohua Li wrote: > @@ -570,7 +570,8 @@ static int kernfs_dop_revalidate(struct dentry *dentry, > unsigned int flags) > goto out_bad; > > /* The kernfs node has been moved? */ > - if (dentry->d_parent->d_fsdata != kn->pare

[PATCH 04/11] kernfs: don't set dentry->d_fsdata

2017-06-02 Thread Shaohua Li
From: Shaohua Li When working on adding exportfs operations in kernfs, I found it's hard to initialize dentry->d_fsdata in the exportfs operations. Looks there is no way to do it without race condition. Look at the kernfs code closely, there is no point to set dentry->d_fsdata. inode->i_private a