Re: [PATCH 04/12] xfs: refactor the ioend merging code

2019-10-15 Thread Dave Chinner
On Tue, Oct 15, 2019 at 05:43:37PM +0200, Christoph Hellwig wrote: > Introduce two nicely abstracted helper, which can be moved to the > iomap code later. Also use list_pop_entry and list_first_entry_or_null > to simplify the code a bit. > > Signed-off-by: Christoph Hellwig looks ok. Reviewed-

Re: [PATCH 04/12] xfs: refactor the ioend merging code

2019-10-15 Thread Christoph Hellwig
On Tue, Oct 15, 2019 at 10:56:19AM -0700, Darrick J. Wong wrote: > On Tue, Oct 15, 2019 at 05:43:37PM +0200, Christoph Hellwig wrote: > > Introduce two nicely abstracted helper, which can be moved to the > > iomap code later. Also use list_pop_entry and list_first_entry_or_null > > to simplify the

Re: [PATCH 04/12] xfs: refactor the ioend merging code

2019-10-15 Thread Darrick J. Wong
On Tue, Oct 15, 2019 at 05:43:37PM +0200, Christoph Hellwig wrote: > Introduce two nicely abstracted helper, which can be moved to the > iomap code later. Also use list_pop_entry and list_first_entry_or_null > to simplify the code a bit. No we don't use these ^^ Everything el

[PATCH 04/12] xfs: refactor the ioend merging code

2019-10-15 Thread Christoph Hellwig
Introduce two nicely abstracted helper, which can be moved to the iomap code later. Also use list_pop_entry and list_first_entry_or_null to simplify the code a bit. Signed-off-by: Christoph Hellwig --- fs/xfs/xfs_aops.c | 73 +++ 1 file changed, 42 in

[PATCH 04/12] xfs: refactor the ioend merging code

2019-07-22 Thread Christoph Hellwig
Introduce two nicely abstracted helper, which can be moved to the iomap code later. Also use list_pop_entry and list_first_entry_or_null to simplify the code a bit. Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong --- fs/xfs/xfs_aops.c | 70 +---