[PATCH 04/13] perf tests: Add another metric parsing test

The test goes through all metrics compiled for arch within pmu events and try to parse them. This test is different from 'test_parsing' in that we go through all the events in the current arch, not just one defined for current CPU model. Using 'fake_pmu' to parse events which do not have PMUs

Re: [PATCH 04/13] perf tests: Add another metric parsing test

On Tue, Jun 2, 2020 at 12:08 PM Jiri Olsa wrote: > > On Tue, Jun 02, 2020 at 10:58:32AM -0700, Ian Rogers wrote: > > SNIP > > > > +static int check_parse_fake(const char *id) > > > +{ > > > + struct parse_events_error error; > > > > nit: this reads funny as it isn't clear, without looking

Re: [PATCH 04/13] perf tests: Add another metric parsing test

On Tue, Jun 02, 2020 at 10:58:32AM -0700, Ian Rogers wrote: SNIP > > +static int check_parse_fake(const char *id) > > +{ > > + struct parse_events_error error; > > nit: this reads funny as it isn't clear, without looking at > check_parse_id, that error is zero initialized. right, how

Re: [PATCH 04/13] perf tests: Add another metric parsing test

On Tue, Jun 02, 2020 at 10:58:32AM -0700, Ian Rogers wrote: > On Tue, Jun 2, 2020 at 4:51 AM Jiri Olsa wrote: > > > > The test goes through all metrics compiled for arch > > within pmu events and try to parse them. > > > > This test is different from 'test_parsing' in that > > we go through all

Re: [PATCH 04/13] perf tests: Add another metric parsing test

On Tue, Jun 2, 2020 at 4:51 AM Jiri Olsa wrote: > > The test goes through all metrics compiled for arch > within pmu events and try to parse them. > > This test is different from 'test_parsing' in that > we go through all the events in the current arch, > not just one defined for current CPU

[PATCH 04/13] perf tests: Add another metric parsing test

The test goes through all metrics compiled for arch within pmu events and try to parse them. This test is different from 'test_parsing' in that we go through all the events in the current arch, not just one defined for current CPU model. Using 'fake_pmu' to parse events which do not have PMUs