Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 19.10.2015 um 13:31 schrieb Alexander Holler: Am 19.10.2015 um 12:57 schrieb Alexander Holler: Am 18.10.2015 um 12:11 schrieb Alexander Holler: Am 18.10.2015 um 07:59 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: Am 18.10.2015 um 07:14

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 19.10.2015 um 13:31 schrieb Alexander Holler: Am 19.10.2015 um 12:57 schrieb Alexander Holler: Am 18.10.2015 um 12:11 schrieb Alexander Holler: Am 18.10.2015 um 07:59 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: Am 18.10.2015 um 07:14

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 19.10.2015 um 12:57 schrieb Alexander Holler: Am 18.10.2015 um 12:11 schrieb Alexander Holler: Am 18.10.2015 um 07:59 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 18.10.2015 um 12:11 schrieb Alexander Holler: Am 18.10.2015 um 07:59 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: Am

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 19.10.2015 um 12:57 schrieb Alexander Holler: Am 18.10.2015 um 12:11 schrieb Alexander Holler: Am 18.10.2015 um 07:59 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 18.10.2015 um 12:11 schrieb Alexander Holler: Am 18.10.2015 um 07:59 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: Am

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 18.10.2015 um 07:59 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: Again,

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: > Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: > >On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: > >>Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: > >> > >>>Again, parallelizing does not solve anything,

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: > Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: > >On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: > >>Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: > >> > >>>Again, parallelizing does not solve anything,

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 18.10.2015 um 07:59 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 07:20:34AM +0200, Alexander Holler wrote: Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: Again,

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: Again, parallelizing does not solve anything, and causes more problems _and_ makes things take longer. Try it, we have done

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: > Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: > > >Again, parallelizing does not solve anything, and causes more problems > >_and_ makes things take longer. Try it, we have done it in the past and > >proven this, it's

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: Again, parallelizing does not solve anything, and causes more problems _and_ makes things take longer. Try it, we have done it in the past and proven this, it's pretty easy to test :) Just because I'm curious, may I ask how I would test that

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:08 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: That isn't a flag day thing. It's a config option everyone can turn on and off whenever he wants. That's a flag-day thing. We've done it (drm comes to mind - several times). I'm

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:58 schrieb Alexander Holler: Unfortunately it's quiet a lot of work to add dependencies for everything. And (just in case of), also I'm a non-native English writer, I know the difference between quiet and quite. But, unfortunately, that doesn't prevent me to type it

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: On Sat, Oct 17, 2015 at 09:14:34PM +0200, Alexander Holler wrote: Am 17.10.2015 um 21:08 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: That isn't a flag day thing. It's a config option everyone can turn

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 12:14 PM, Alexander Holler wrote: > > It's impossible to take it into account because I don't want to miss the > parallelize functionality. And without that, all the stuff doesn't offer > enough benefits to be worse the effort but just adds some time necessary to > do the

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 09:14:34PM +0200, Alexander Holler wrote: > Am 17.10.2015 um 21:08 schrieb Linus Torvalds: > >On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler > >wrote: > >> > >>That isn't a flag day thing. It's a config option everyone can turn on and > >>off whenever he wants. > > >

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:08 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: That isn't a flag day thing. It's a config option everyone can turn on and off whenever he wants. That's a flag-day thing. We've done it (drm comes to mind - several times). I'm

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: > > That isn't a flag day thing. It's a config option everyone can turn on and > off whenever he wants. That's a flag-day thing. We've done it (drm comes to mind - several times). I'm disappointed, because I _know_ I pointed you in the

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:03 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 11:37 AM, Alexander Holler wrote: Otherwise it's impossible to call initcalls in parallel. I've seen a stable topological sort somewhere, but whenever you want to parallelize the initcalls, the stable ordering would be

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 11:37 AM, Alexander Holler wrote: > > Otherwise it's impossible to call initcalls in parallel. I've seen a stable > topological sort somewhere, but whenever you want to parallelize the > initcalls, the stable ordering would be gone anyway. So I've decided not to > look

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 20:52 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 11:37 AM, Alexander Holler wrote: I'm making dependencies the only ordering for annotated initcalls. Yeah, and quite frankly, that just means that I'm not going to merge it. We do not do "flag-day" things. We've done

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 08:37:35PM +0200, Alexander Holler wrote: > I'm making dependencies the only ordering for annotated initcalls. > > Otherwise it's impossible to call initcalls in parallel. We don't ever want to call initcalls in parallel, unless they can properly handle it. All drivers

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 11:37 AM, Alexander Holler wrote: > > I'm making dependencies the only ordering for annotated initcalls. Yeah, and quite frankly, that just means that I'm not going to merge it. We do not do "flag-day" things. We've done them in the past, and it has always been a major

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 20:23 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 10:14 AM, Alexander Holler wrote: Assuming three different ethernet-drivers, without any special code, the dependency graph would not require any special order inbetween them and would look like that: This seems

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 10:14 AM, Alexander Holler wrote: > > Assuming three different ethernet-drivers, without any special code, > the dependency graph would not require any special order inbetween them > and would look like that: This seems *fundamentally* wrong. This is in no way specific

[PATCH 04/14] init: deps: order network interfaces by link order

In order to provide stable interface numbers, network interface drivers will be ordered by the link order. This is easy to accomplish by adding dependencies. Assuming three different ethernet-drivers, without any special code, the dependency graph would not require any special order inbetween

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: > Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: > > >Again, parallelizing does not solve anything, and causes more problems > >_and_ makes things take longer. Try it, we have done it in the past and > >proven this, it's

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 18.10.2015 um 07:14 schrieb Greg Kroah-Hartman: On Sun, Oct 18, 2015 at 06:59:22AM +0200, Alexander Holler wrote: Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: Again, parallelizing does not solve anything, and causes more problems _and_ makes things take longer. Try it, we have done

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: Again, parallelizing does not solve anything, and causes more problems _and_ makes things take longer. Try it, we have done it in the past and proven this, it's pretty easy to test :) Just because I'm curious, may I ask how I would test that

[PATCH 04/14] init: deps: order network interfaces by link order

In order to provide stable interface numbers, network interface drivers will be ordered by the link order. This is easy to accomplish by adding dependencies. Assuming three different ethernet-drivers, without any special code, the dependency graph would not require any special order inbetween

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 10:14 AM, Alexander Holler wrote: > > Assuming three different ethernet-drivers, without any special code, > the dependency graph would not require any special order inbetween them > and would look like that: This seems *fundamentally* wrong. This

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 11:37 AM, Alexander Holler wrote: > > I'm making dependencies the only ordering for annotated initcalls. Yeah, and quite frankly, that just means that I'm not going to merge it. We do not do "flag-day" things. We've done them in the past, and it has

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 08:37:35PM +0200, Alexander Holler wrote: > I'm making dependencies the only ordering for annotated initcalls. > > Otherwise it's impossible to call initcalls in parallel. We don't ever want to call initcalls in parallel, unless they can properly handle it. All drivers

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:03 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 11:37 AM, Alexander Holler wrote: Otherwise it's impossible to call initcalls in parallel. I've seen a stable topological sort somewhere, but whenever you want to parallelize the initcalls, the stable

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: > > That isn't a flag day thing. It's a config option everyone can turn on and > off whenever he wants. That's a flag-day thing. We've done it (drm comes to mind - several times). I'm disappointed, because I _know_

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 20:23 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 10:14 AM, Alexander Holler wrote: Assuming three different ethernet-drivers, without any special code, the dependency graph would not require any special order inbetween them and would look like that:

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 20:52 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 11:37 AM, Alexander Holler wrote: I'm making dependencies the only ordering for annotated initcalls. Yeah, and quite frankly, that just means that I'm not going to merge it. We do not do "flag-day"

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 11:37 AM, Alexander Holler wrote: > > Otherwise it's impossible to call initcalls in parallel. I've seen a stable > topological sort somewhere, but whenever you want to parallelize the > initcalls, the stable ordering would be gone anyway. So I've

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:08 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: That isn't a flag day thing. It's a config option everyone can turn on and off whenever he wants. That's a flag-day thing. We've done it (drm comes to mind -

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 09:14:34PM +0200, Alexander Holler wrote: > Am 17.10.2015 um 21:08 schrieb Linus Torvalds: > >On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler > >wrote: > >> > >>That isn't a flag day thing. It's a config option everyone can turn on and > >>off

Re: [PATCH 04/14] init: deps: order network interfaces by link order

On Sat, Oct 17, 2015 at 12:14 PM, Alexander Holler wrote: > > It's impossible to take it into account because I don't want to miss the > parallelize functionality. And without that, all the stuff doesn't offer > enough benefits to be worse the effort but just adds some time

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: On Sat, Oct 17, 2015 at 09:14:34PM +0200, Alexander Holler wrote: Am 17.10.2015 um 21:08 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: That isn't a flag day thing. It's a config

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:58 schrieb Alexander Holler: Unfortunately it's quiet a lot of work to add dependencies for everything. And (just in case of), also I'm a non-native English writer, I know the difference between quiet and quite. But, unfortunately, that doesn't prevent me to type it

Re: [PATCH 04/14] init: deps: order network interfaces by link order

Am 17.10.2015 um 21:08 schrieb Linus Torvalds: On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: That isn't a flag day thing. It's a config option everyone can turn on and off whenever he wants. That's a flag-day thing. We've done it (drm comes to mind -